Jørgen Schartum Dokken

Results 276 comments of Jørgen Schartum Dokken

> > > ``` > > > * Could `basix.ufl_wrapper` be `basix.ufl`? The former is a bit long and ugly > > > ``` > > > > > >...

> `SameMinorVersion` @drew-parsons If we run with SameMinorVersion, one would force the user to use: ```cmake find_package(DOLFINX 0.6.0...

> You're absolutely right, this is the key point. Will the API be substantially changing in every 0.x release, requiring users to modify their existing code? Across 0.4 to 0.5,...

> Whether an API change actually breaks a downstream package is not important (e.g. they only use a limited subset of the API). It is for downstream users and developers...

No, this is still not resolved. You get the issue by adding `V_v.sub(i)` `i` being 0, 1 or 2 to the example above. You then get issues when creating the...

> Is there a sensible test we can add to DOLFINx that will check that we don't break this in future? Good question, maybe we need to solve a PDE...

A suggested fix for this issue has been outlined in: https://github.com/FEniCS/dolfinx/issues/3063#issuecomment-1962057089

> I've now got a [branch of TSFC](https://github.com/firedrakeproject/tsfc/pull/272) where this works. I haven't implemented the necessary bits to achieve any performance improvements since we touch code using `subdomain_id` in a...

> > > I've now got a [branch of TSFC](https://github.com/firedrakeproject/tsfc/pull/272) where this works. I haven't implemented the necessary bits to achieve any performance improvements since we touch code using `subdomain_id`...

@dham @connorjward I'm planning to merge this sometime this week, as the FEniCSx integration tests are passing, and this yields a significant speedup for form-compilation of forms with many subdomains....