Jordan

Results 31 comments of Jordan
trafficstars

I could do that, but perhaps a better way would be to copy-paste the contents of `make_move` into `make_move_new`. So, the new version would look like this: ```rust pub fn...

So, the issue with what you're requesting is pretty simple. Having the half-move clock would allow you to declare draw by 50 move rule. However, having the half-move clock would...

The benefit is quite simple: FEN is a description of the current board state, which does not contain a move counter. PGN is a description of the game state, with...

This looks good to me. I don't see any reason to avoid merging. Is this ready to go?

I'll probably do a squash and merge. I generally prefer that.

I don't really think I care either way. `repr(u8)` seems like it would _allow_ `mem::transmute`, but I doubt it's that useful in the first place. Any time I can imagine...

This one is a bit tricky for me. This evil code-path is only possible if there are more pieces on the chess board than can exist on a chess board...

I believe the following would resolve the unsoundness as well, but again I'd need to check more deeply: If all the following is done in `Board`, I believe there would...

* So, on the `is_sane` function, I think it's safe to assume _already_ that no `Board` should be constructable using the public API that causes `is_sane` to return `false`. The...

> Thanks. I expect that the benchmark result depends heavily on the work load, the CPU architecture and the compiler (version). Yeah, benchmarks are very tricky. You gotta be very...