react-native-webview-crosswalk icon indicating copy to clipboard operation
react-native-webview-crosswalk copied to clipboard

Fails to build with React-Native 0.52

Open romanlv opened this issue 7 years ago • 4 comments

react-native run-android gives

:CrosswalkWebView:incrementalReleaseJavaCompilationSafeguard UP-TO-DATE
:CrosswalkWebView:compileReleaseJavaWithJavac
:CrosswalkWebView:compileReleaseJavaWithJavac - is not incremental (e.g. outputs have changed, no previous execution, etc.).
/Users/user/dev/tests/crosswalk-test/node_modules/react-native-webview-crosswalk/src/main/java/com/jordansexton/react/crosswalk/webview/CrosswalkWebViewPackage.java:26: error: method does not override or implement a method from a supertype
    @Override
    ^
Note: /Users/user/dev/tests/crosswalk-test/node_modules/react-native-webview-crosswalk/src/main/java/com/jordansexton/react/crosswalk/webview/CrosswalkWebViewGroupManager.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: /Users/user/dev/tests/crosswalk-test/node_modules/react-native-webview-crosswalk/src/main/java/com/jordansexton/react/crosswalk/webview/CrosswalkWebViewGroupManager.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
1 error
:CrosswalkWebView:compileReleaseJavaWithJavac FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':CrosswalkWebView:compileReleaseJavaWithJavac'.
> Compilation failed; see the compiler error output for details.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

Problem can be reproduced in demo project

romanlv avatar Jan 30 '18 18:01 romanlv

I have the same problem (0.5.0 and RN 0.51.0)

edit: I just downgraded to 0.4.0, and still have the same issue, so it must have been something else. @romanlv can you confirm it happens on 0.4.0 with + your code?

ajRiverav avatar Mar 04 '18 07:03 ajRiverav

I have the same problem. What version rnwc, react-native, react i should use?

maksimis avatar Mar 16 '18 13:03 maksimis

+1

vartana avatar Apr 16 '18 07:04 vartana

btw, Android 4.4 (KitKat), the WebView component is based on the Chromium so you may not need this implementation at all. It is not the case for iOS, where wkwebview has much better performance

romanlv avatar Apr 16 '18 16:04 romanlv