joomla-websites icon indicating copy to clipboard operation
joomla-websites copied to clipboard

[jorg] Wrong Logo

Open coolcat-creations opened this issue 3 years ago • 8 comments

This is not the correct Joomla Logo

grafik

coolcat-creations avatar Dec 05 '22 16:12 coolcat-creations

What's wrong with it? https://cdn.joomla.org/images/Joomla_logo.png

HLeithner avatar Dec 05 '22 16:12 HLeithner

The font next to the brandmark is wrong. Look at joomla.de there is the right logo.

coolcat-creations avatar Dec 05 '22 16:12 coolcat-creations

It's not part of the logo it's the Sitename... but yes doesn't look good. Should be fixed in the template but at the moment jxt is working on a new template and there is no volunteers available for polishing the CDN template. So I would expect the new template comes before this will be fixed, so I'm closing this for now.

HLeithner avatar Dec 05 '22 17:12 HLeithner

Can you link it to the PR or if no PR is available then leave it open? I mean otherwise someone will report it again?

coolcat-creations avatar Dec 05 '22 17:12 coolcat-creations

@HLeithner can we reopen this as its not fixed yet?

coolcat-creations avatar Sep 18 '24 13:09 coolcat-creations

Based on the validity of the Joomla CI (from 2017), the word mark Joomla is displayed in the wrong font. Therefore, I reopen the issue.

max123kl avatar Sep 18 '24 13:09 max123kl

Good!

Ok this is in the template now:

<h1 class="page-title">
    <a href="<?php echo $this->baseurl; ?>/"><span aria-hidden="true" class="icon-joomla me-2"></span><?php echo HTMLHelper::_('string.truncate', $sitename, 40, false, false);?></a>
</h1>

I'm no seo/accessibility expert so i would like to know from one that is, if we remove Joomla! as text and replace it with an image. What would we need to do to change this properly?

<h1 class="page-title">
    <a href="<?php echo $this->baseurl; ?>/">
        <img src="logo.svg" / title="Joomla!" class="site-logo me-2">
        <?php echo $param->site_title;?>
    </a>
</h1>

I would create a new param in the template where we can add a custom site title that does not include the Joomla! name.

Then use that after the logo.

Would adding the title tag to the image be sufficient or do we need to do more here for SEO and accessibility?

TLWebdesign avatar Sep 18 '24 14:09 TLWebdesign

<h1 class="page-title">
    <a href="<?php echo $this->baseurl; ?>/">
        <img src="logo.svg" alt="Joomla!" class="site-logo me-2">
        <?php echo $param->site_title;?>
    </a>
</h1>t

I suggest adding an alt-text to lgo image because it must be annonced that this is Joomla!. The image is part of the link but it is not the link itself.

chmst avatar Sep 19 '24 11:09 chmst

Ok so who do we need to ask (permission) to change this? We should also add a parameter to the template because the site title will not be suitable since it holds the Joomla text also. And that part we now want to replace with joomla logo instead. I know how to do all this. Is there a REPO of the joomla template? the joomla.org repo doesn't hold the current template files.

TLWebdesign avatar Sep 26 '24 21:09 TLWebdesign

Repo lives at https://github.com/joomla/jdotorgtemplate

It’s a private one so people can’t reproduce the websites so easily. I’ll get you added in. It’s not supposed to be super secret

wilsonge avatar Oct 08 '24 10:10 wilsonge

@wilsonge how do i know if it exists and what the filename is of the joomla svg logo on the cdn.joomla.org?

TLWebdesign avatar Oct 09 '24 15:10 TLWebdesign

Hi, this issue has been fixed in the latest template version which has rolled out to tm.joomla.org. Please have a look and let me know if you think it still needs some changes.

TLWebdesign avatar Nov 07 '24 12:11 TLWebdesign

Really not convinced how it works on mobile to be honest. Wondering if we need to drop the Joomla text completely on mobile and just have the icon

wilsonge avatar Nov 07 '24 12:11 wilsonge

What exactly don't you like because if i look at the old community website how it behaves it's almost identical.

TLWebdesign avatar Nov 07 '24 13:11 TLWebdesign

Can we make the Logo and Text way smaller ? (Trademark) it does not have to be so big... :-) Image

Image

coolcat-creations avatar Nov 07 '24 14:11 coolcat-creations

Sure. Let me know what sizes you have in mind and I can shove it into the scss

wilsonge avatar Nov 10 '24 15:11 wilsonge

For the Logo for example 137 x 35 px with margin right of 30px and for the title: 20px or it's according rem value. Thank you @wilsonge

coolcat-creations avatar Nov 11 '24 12:11 coolcat-creations

Tried this locally - and cause we make the buttons large - it's just felt very out of place. So just going to leave it as it is for now. Rolled it out over all the other j4 sites though.

wilsonge avatar Nov 23 '24 00:11 wilsonge