joomla-cms icon indicating copy to clipboard operation
joomla-cms copied to clipboard

[5.3] Remove Fields button for custom module

Open brianteeman opened this issue 6 months ago • 5 comments

Summary of Changes

This PR removes the Fields button from the custom HTML module as it cannot be used here and should not be presented

Testing Instructions

Test with both the editor set to tinymce and with the editor set to none. When set to tinymce the buttons are in the CMS Content Dropdown. When set to any other editor the buttons are below the text area

Make sure to test front end module editing as well

Actual result BEFORE applying this Pull Request

image

image

Expected result AFTER applying this Pull Request

image

image

Link to documentations

Please select:

  • [ ] Documentation link for docs.joomla.org:

  • [x] No documentation changes for docs.joomla.org needed

  • [ ] Pull Request link for manual.joomla.org:

  • [x] No documentation changes for manual.joomla.org needed

brianteeman avatar Jun 12 '25 06:06 brianteeman

Changes in the hide attribute work as expected.

I am wondering about the labels. They are not used at all, changing to _LABEL1 has no effect but is not in the Language file.

chmst avatar Jun 12 '25 07:06 chmst

Changes in the hide attribute work as expected.

I am wondering about the labels. They are not used at all, changing to _LABEL1 has no effect but is not in the Language file.

sorry that was a remnant from testing

brianteeman avatar Jun 12 '25 07:06 brianteeman

I have tested this item :white_check_mark: successfully on 55132e0152b278d252d06a7012d8d4a917303dab


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45600.

chmst avatar Jun 12 '25 07:06 chmst

I have tested this item :white_check_mark: successfully on 55132e0152b278d252d06a7012d8d4a917303dab

Thank you


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45600.

web-eau-net avatar Jun 12 '25 08:06 web-eau-net

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45600.

richard67 avatar Jun 12 '25 10:06 richard67

Thanks

rdeutz avatar Jun 19 '25 15:06 rdeutz