joomla-cms
joomla-cms copied to clipboard
[5.3] New article from frontend send mail with Mailtemplate
Pull Request for Issue #43872 .
Summary of Changes
use the mail template instead of com_messages
Testing Instructions
send an article from frontend and check the email
Actual result BEFORE applying this Pull Request
N/A
Expected result AFTER applying this Pull Request
the email is configurable with Mailtemplates
Link to documentations
Please select:
-
[ ] Documentation link for docs.joomla.org:
-
[ ] No documentation changes for docs.joomla.org needed
-
[ ] Pull Request link for manual.joomla.org:
-
[ ] No documentation changes for manual.joomla.org needed
I have tested this item :white_check_mark: successfully on db74a7f8b2919b4c9c611e0f675fa66a748a6277
Before PR: article creation ---> email notification that there is a personal message. In the personal message in the panel there is information about a new article that was created by this and that.
After PR: article creation ---> email notification that such and such an article was created, written by that and that.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44243.
I have tested this item :red_circle: unsuccessfully on 014ac4ebc3ea616abf6cbc0a50613f653e99870b
Tested on: Joomla! 5.3-dev
Patch Applied Using: Joomla! Patch Tester
Steps Followed for Testing:
- Applied the patch via Patch Tester.
- Verified that mail settings are correctly configured.
- Submitted a new article from the frontend.
- Checked the email inbox for notifications.
Issue Observed:
- No email was received.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44243.
I have tested this item :red_circle: unsuccessfully on 014ac4ebc3ea616abf6cbc0a50613f653e99870b
Tested on: Joomla! 5.3-dev on the test server
Patch Applied Using: Joomla! Patch Tester
Before: email was sent with mail template After: email was sent with mail template
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44243.
thanks for testing and for feedback
it was working in October 24 😄
i'll re-check and i'll make it after available for test again
@alikon You have to rename the update SQL scripts to something newer than the newest in the branch, which is 5.3.0-2025-02-09.sql, so rename to e.g. 5.3.0-2025-02-22.sql. That'S the reason why your update SQL does not run when people update with the patched package from Drone.
And the PR has a conflict which needs to be resolved. If necessary I can help, but not before tonight.
@komalm @crommie As this PR also makes database changes, it is not enought to apply the patch with patch tester, it also needs to apply the database changes from the update SQL script e.g. with phpMyAdmin, or to use the update package created by Drone, but that would currently not work, see my previous comment for explanation.
@alikon Please update your testing instructions to make that clear.
Plus the notifications were already using the email templates without the patch.
as there is no entry in the #__mail_templates table before this pr on the current 5.3-dev branch
i really doubt that notification for this event use the mail template
@crommie can you clarify how you got that ?
Only scenario I can think of is: I might have fired the scheduled task without enabling email, then got confused, then enabled email, applied patch, fired task, got email from email template, reverted patch, fired task and got email from template again.
The only part I'm 100% sure of is I did fire it both with patch applied and with patch reverted and in both cases it used email template.
Only scenario I can think of is: I might have fired the scheduled task without enabling email, then got confused, then enabled email, applied patch, fired task, got email from email template, reverted patch, fired task and got email from template again.
The only part I'm 100% sure of is I did fire it both with patch applied and with patch reverted and in both cases it used email template.
You want me to test again on a clean site? And if so: are the PBF sites still there?
This pull request has been automatically rebased to 6.0-dev.
i'll not invest much more time on this