joomla-cms icon indicating copy to clipboard operation
joomla-cms copied to clipboard

[6.0] Move CMS Filesystem package to compat plugin

Open Hackwar opened this issue 1 year ago • 2 comments

Summary of Changes

This PR moves the CMS Filesystem classes to the compat plugin, allowing legacy third party code to still run when the plugin is active, but making the first step to finally remove it from the CMS.

I've added the Composer Dependency Changed label because the PR requires composer i to be run.

Testing Instructions

Copy the following line in a view of your choice to generate a call to the legacy classes:

var_dump(\Joomla\CMS\Filesystem\Folder::listFolderTree(JPATH_BASE, '.'));

Make sure the compat plugin is enabled AND you have to run composer i to generate an updated class loader file Visit the view you edited in the browser to see an output of the call to the legacy class. Disable the plugin and see an error thrown instead.

Link to documentations

Please select:

  • [ ] Documentation link for docs.joomla.org:

  • [ ] No documentation changes for docs.joomla.org needed

  • [ ] Pull Request link for manual.joomla.org:

  • [ ] No documentation changes for manual.joomla.org needed

Hackwar avatar Oct 12 '24 12:10 Hackwar

Please move the "classes" folder outside of the src folder. Like it is now you have the src folder managed by a classloader and then the "classes" folder managed by another classloader. I would also rename the "classes" folder to legacy or so.

laoneo avatar Oct 14 '24 06:10 laoneo

Done

Hackwar avatar Oct 14 '24 08:10 Hackwar

Thanks for all the work on these @Hackwar, can you resolve this little conflict? Then we can merge.

Bodge-IT avatar Feb 12 '25 08:02 Bodge-IT

I have tested this item :white_check_mark: successfully on f7007b8f766441d71cb7f010cc7b5b690a7fbdfa

Good test after full wipe.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44240.

Bodge-IT avatar Mar 03 '25 21:03 Bodge-IT

Tested that the folder did not exist and then it all worked. Better testing instructions please


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44240.

softforge avatar Mar 03 '25 21:03 softforge

I have tested this item :white_check_mark: successfully on f7007b8f766441d71cb7f010cc7b5b690a7fbdfa

When I worked out what was actually needed... it worked


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44240.

softforge avatar Mar 03 '25 21:03 softforge