joomla-cms icon indicating copy to clipboard operation
joomla-cms copied to clipboard

[J5.2] Cassiopeia - Only add margin to system message container if it contains a joomla-alert

Open coolcat-creations opened this issue 1 year ago • 4 comments

Pull Request for Issue #40639.

Summary of Changes

Added a :has rule to control the margin of the system-message-container if it does not contain a tag :has selector is supported by all modern browsers

grafik

Testing Instructions

login with wrong credentials in your cassiopeia frontend. A system message appears that the login data is wrong Click the close button to hide the message

Actual result BEFORE applying this Pull Request

After hiding a system alert, a margin of 1rem remains

Expected result AFTER applying this Pull Request

After hiding a system alert, the margin is not present anymore

Link to documentations

Please select:

  • [ ] Documentation link for docs.joomla.org:

  • [x ] No documentation changes for docs.joomla.org needed

  • [ ] Pull Request link for manual.joomla.org:

  • [x ] No documentation changes for manual.joomla.org needed

coolcat-creations avatar Oct 10 '24 08:10 coolcat-creations

I have tested this item :white_check_mark: successfully on 97d020908cf2431984ab1a4e820786ac4370addd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44222.

ghost avatar Oct 10 '24 09:10 ghost

I have tested this item :white_check_mark: successfully on 97d020908cf2431984ab1a4e820786ac4370addd

with NPM Package


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44222.

ChristineWk avatar Oct 10 '24 10:10 ChristineWk

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44222.

richard67 avatar Oct 10 '24 12:10 richard67

I have tested this item :white_check_mark: successfully on 97d020908cf2431984ab1a4e820786ac4370addd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44222.

brianteeman avatar Oct 10 '24 13:10 brianteeman

Thanks @coolcat-creations !

pe7er avatar Oct 26 '24 17:10 pe7er

Thank you for merging!

coolcat-creations avatar Oct 26 '24 22:10 coolcat-creations