[J5.2] Fixing Cassiopeia mobile menu collapse bug #44140

[coolcat-creations]

Pull Request for Issue #44140 .

Summary of Changes

Took the code advise from @dgrammatiko inside the issue and tested working

Testing Instructions

Follow the error description from #44140 in Chrome

Actual result BEFORE applying this Pull Request

Submenus stop expanding

Expected result AFTER applying this Pull Request

Submenus stay at their last state and are still operable

Thank you @dgrammatiko for the fix!

Link to documentations

Please select:

• [ ] Documentation link for docs.joomla.org:

• [x ] No documentation changes for docs.joomla.org needed

• [ ] Pull Request link for manual.joomla.org:

• [x ] No documentation changes for manual.joomla.org needed

[richard67]

@coolcat-creations This PR updates some NPM dependencies. See the changes in file "package-lock.json" showsn on GitHub (if you expand the changes). Is that by purpose, or is it a mistake?

[coolcat-creations]

@richard67 Its a mistake, I made a npm update and that happened then, how can I revert this?

[richard67]

@richard67 Its a mistake, I made a npm update and that happened then, how can I revert this?

@coolcat-creations Revert what? The npm update? Or the changed "package-lock.json" in this PR?

Where did the npm update happen? Only on the branch or this PR? Or on your 5.2-dev branch?

If it's only the branch of this PR, the easiest way is to close the PR and delete the branch of this PR, create a new branch with a different branch name and then use that new branch to redo your change in a new PR.

[coolcat-creations]

I made the npm update and apparently this created the changed package-lock — can we just revert this one file somehow?

[richard67]

I made the npm update and apparently this created the changed package-lock — can we just revert this one file somehow?

@coolcat-creations Sure. But as I don't know which Git client you are using, or which IDE, I can't advise how to do that, and explaining how to do it with the command line and a git command would be too long now. Alternatively you could take the file from a clean 5.2-dev branch, put it into your branch for this PR and commit and push the change. Then check on GitHub if the file is still shown among the changed files. It should not be shown anymore when that was done right.

[dgrammatiko]

Just copy the contents from the GitHub https://github.com/joomla/joomla-cms/blob/5.2-dev/package-lock.json and push it on your repo

[HLeithner]

This pull request has been automatically rebased to 5.3-dev.

[MacJoom]

I have tested this item :white_check_mark: successfully on 0a0c8f7ff4e9a111b3bba09ea6e9a09998207109

Could reproduce the issue on cassiopeia hamburger mobile menu opening submenus (e.g. Sample Layouts) and closing the whole menu after around 5-10 times - submenu did not open anymore. after installing the patch (and npm ci) i was not able to reproduce the issue

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44221.}

[exlemor]

I have tested this item :white_check_mark: successfully on f0c2a7bca8b5816771096280c0744f0a5eaeef6d

I have tested this successfully during PBF 23.08 with Martin in the other window ;)

Thanks @coolcat-creations!

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44221.}

[richard67]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44221.}

[rdeutz]

Thanks