joomla-cms icon indicating copy to clipboard operation
joomla-cms copied to clipboard

Avoid strlen for admin submenu items

Open chmst opened this issue 1 year ago • 1 comments

Pull Request for Issue #43715, #39758

Credits @Hackwar

Summary of Changes

Remove empty values from request

Testing Instructions

see #43715, #39758

Actual result BEFORE applying this Pull Request

Error message when adding or editing a menuItemType in some cases - see description in #43715, #39758

Expected result AFTER applying this Pull Request

MenuItemTypes can be selected and edited

Link to documentations

Please select:

  • [ ] Documentation link for docs.joomla.org:

  • [x] No documentation changes for docs.joomla.org needed

  • [ ] Pull Request link for manual.joomla.org:

  • [x] No documentation changes for manual.joomla.org needed

chmst avatar Aug 05 '24 20:08 chmst

          The error should be triggerable with a URL like this in the manifest of a component: `index.php?option=com_foo&id[]=x`

Originally posted by @Hackwar in https://github.com/joomla/joomla-cms/issues/43715#issuecomment-2268439051

Can someone tell me where to find the "manifest"-file for "com_content" or another component (i can't trigger the bug)?

ghost avatar Aug 27 '24 13:08 ghost

Please rebase for 5.2.

Quy avatar Oct 24 '24 05:10 Quy

I have tested this item :white_check_mark: successfully on df46b340ef4d62be780571c15faab76db994b9af


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43884.

Quy avatar Oct 27 '24 15:10 Quy

I have tested this item :white_check_mark: successfully on df46b340ef4d62be780571c15faab76db994b9af


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43884.

viocassel avatar Oct 31 '24 06:10 viocassel

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43884.

alikon avatar Oct 31 '24 07:10 alikon