[5.2][Events] Use event classes for Sampledata plugins

[Fedik]

Summary of Changes

Update sampledata plugins to use SubscriberInterface and event classes.

Testing Instructions

Try to install sample data, of each type. All should work as before.

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works

Link to documentations

Please select:

• [ ] Documentation link for docs.joomla.org:
• [ ] No documentation changes for docs.joomla.org needed
• [x] Pull Request link for manual.joomla.org: https://github.com/joomla/Manual/pull/177
• [ ] No documentation changes for manual.joomla.org needed

[exlemor]

@Fedik

I am getting this error message when I try to Apply Patch:

The file marked for modification does not exist: plugins/sampledata/testing/src/Extension/Testing.php

Am I doing something wrong? (sampledata it NOT yet installed)

[Fedik]

It maybe you use patch tester on regular Joomla installation? The thing is, that sampledata/testing exist only in DEV installation from the git.

[exlemor]

It maybe you use patch tester on regular Joomla installation? The thing is, that sampledata/testing exist only in DEV installation from the git.

You are correct - a standard Joomla test site of 5.1.2 that I spun up for testing. I didn't see anything in the instructions that said Dev installation or git requirement or equivalent so I did as usual, sorry ;(

[Fedik]

@exlemor I would say, if other sampledata works then we can count it as success :wink: the testing sampledata DEVs will test after merging :smile:

[exlemor]

@exlemor I would say, if other sampledata works then we can count it as success 😉 the testing sampledata DEVs will test after merging 😄

I apologize for not understanding the above message - but just to clarify, I have a standard Joomla 5.1.2 installation, I have Joomla Patch Tester installed and when I try to Apply Patch I get that error message - so I can't try to install the Blog Sample Data or the Multilingual Sample Data since I get that error in red and the patch doesn't apply.

(sorry for being confused) (see attached screenshot if that helps)

[brianteeman]

@fedik you cant use patchtester for this PR with a released version of Joomla. As the testing sampledata is only in the dev git clone patchtester fails to apply this pr so @exlemor cannot test even the regular testing plugins.

[exlemor]

@Fedik you cant use patchtester for this PR with a released version of Joomla. As the testing sampledata is only in the dev git clone patchtester fails to apply this pr so @exlemor cannot test even the regular testing plugins.

Thanks for the explanation @brianteeman.

[exlemor]

I have tested this item :white_check_mark: successfully on f382f4bda25f6421b56cfd5f762ea0218d5dac20

Now that I am on a Joomla 5.2.0 beta2 dev environment I was able to test it and it seems successful indeed.

I did find a small bug: if you click on install Testing Sample Data, it installs, you go somewhere else in Joomla and come back to try to install it again, it fails with a logical error: Step 1 Failed: Another Tag has the same alias (remember it may be a trashed item). BUT this makes Blog Sample Data or Multilingual Sample Data's install button not work - you have to reload the entire page for those Install buttons to refection.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43636.}

[ghost]

Now that I am on a Joomla 5.2.0 beta2 dev environment I was able to test it

@exlemor how do you get sample data testing.zip? I'm also on Joomla 5.2.0 beta2 dev (nightly builds) but find only blog and multilang-plugins of sampla data in the backend.

[exlemor]

Hi fgsw, unless I misunderstood your question, that Testing Sample Data is already installed in one of the Joomla! 5 Server list - sponsored by Wicked Software which we used yesterday during PBF (I also used my own server 5.2 beta 1 for some PR tests but that installation did not have the file)

[brianteeman]

The testing sample data plugin is removed from all releases - including beta. It is only present if you install from a github clone

[HLeithner]

This pull request has been automatically rebased to 5.3-dev.

[ghost]

No Prebuilt package is available for download.

Is it enough to test multilang- and blog sample data (no sample data plugin beside install from a github clone)?

[Fedik]

No Prebuilt package is available for download.

I updated the branch, the prebuilt package should be available again in few sec/min.

Is it enough to test multilang- and blog sample data

Yes

[ghost]

I have tested this item :white_check_mark: successfully on bd9cf02e3e1678fd101e64acb0b5885a976d7333

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43636.}

[laoneo]

Thanks!