joomla-cms icon indicating copy to clipboard operation
joomla-cms copied to clipboard

[4.4] Unclear instruction on joomla update

Open ChristineWk opened this issue 1 year ago • 17 comments

Steps to reproduce the issue

The checkbox is invisible. It is not clear that you have to click this button before the update. It's just a note that a backup is recommended.

Expected result

There should be a different text there, something like "Only after confirmation ............ etc." Because it is not obvious that you "have to" click on the checkbox beforehand.

The checkbox should be more visible.

System information (as much as possible)

Joomla 4 and above

ChristineWk avatar Apr 30 '24 20:04 ChristineWk

update-info

ChristineWk avatar Apr 30 '24 20:04 ChristineWk

Hi @ChristineWk, great thought.

To make it easier and to have it go through faster, it would be great if you proposed a or a couple of better versions, then a PR can be made easily/faster if found to make sense.

exlemor avatar May 01 '24 01:05 exlemor

Language Constant is: COM_JOOMLAUPDATE_UPDATE_CONFIRM_BACKUP

example for CSS:

.com_joomlaupdate .form-check-input[type=checkbox] { outline: medium solid var(--focus); outline-offset: .2em; }


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43408.

Sieger66 avatar May 01 '24 09:05 Sieger66

We all are german and need help of a native speaker. My suggestion is something like "yes, I am aware that a backup is highly recommended before starting the backup"

Other checkboxes in list views have been improved in 5.1. https://github.com/joomla/joomla-cms/issues/41400

chmst avatar May 01 '24 10:05 chmst

Maybe the german needs adjusting, I don't know, but the english makes perfect sense to me (now that the checkbox is more visible)

brianteeman avatar May 02 '24 10:05 brianteeman

Agree with instructions. English is clear, German is not @tecpromotion

But the issue of invisible check box remains. Other checkboxes are better now, but not this one. It has another class than the checkboxes in listviews.

grafik

chmst avatar May 02 '24 18:05 chmst

@ChristineWk @chmst https://github.com/joomlagerman/joomla/issues/new/choose

tecpromotion avatar May 02 '24 18:05 tecpromotion

But the issue of invisible check box remains. Other checkboxes are better now, but not this one. It has another class than the checkboxes in listviews.

Don't forget that in the screenshot the checkbox is disabled. Its not enabled (and more visible) until you have selected a file

image

image

brianteeman avatar May 04 '24 06:05 brianteeman

Text is more visible, but checkbox still isn't. This would solve it: Change: --form-check-input-border: var(--border-width) solid var(--template-bg-dark-20); to --form-check-input-border: var(--border-width) solid var(--template-bg-dark-80); 2024-05-04 Screenshot 329

Pinkeltje avatar May 04 '24 07:05 Pinkeltje

I think that a more userfriendly solution would be: Hide the second block until the user has selected a file, then make it visible. Then it is not necessary to disable a text which for users looks like a bug and has no a11y contrast.

chmst avatar May 04 '24 07:05 chmst

Text or images of text that are part of an inactive user interface component, that are pure decoration, that are not visible to anyone, or that are part of a picture that contains significant other visual content, have no contrast requirement.

https://www.w3.org/TR/UNDERSTANDING-WCAG20/visual-audio-contrast-contrast.html

brianteeman avatar May 04 '24 07:05 brianteeman

I know that and did not label it as a11y issue.

chmst avatar May 04 '24 07:05 chmst

has no a11y contrast.

sorry, i saw that so commented

brianteeman avatar May 04 '24 07:05 brianteeman

The original issue is not about the text but about the checkbox that is barely visible. One of my customers called me some time ago with the same issue "can't update". Turned out he hadn't seen the checkbox. Joomla 4 2024-05-04 Screenshot 332 Joomla 5 2024-05-04 Screenshot 333 Different css though: .form-check-input { border: var(--border-width)solid var(--border-color); } --border-color: #dee2e6;

Pinkeltje avatar May 04 '24 07:05 Pinkeltje

The issue joomlagerman is outsourced and therefore treated separately. Thanks for the suggestions about the checkbox.

ChristineWk avatar May 04 '24 09:05 ChristineWk

I'm sorry it looks like i have closed this ticket here in the wrong tracker. Will reopen here and move my comment to the correct issue.

zero-24 avatar Jun 08 '24 20:06 zero-24