joomla-cms icon indicating copy to clipboard operation
joomla-cms copied to clipboard

Published 20 hours ago • verified publisher icon joomla

[5.2] Adding missing properties to backend component view classes

Open Hackwar opened this issue 1 year ago • 1 comments

Summary of Changes

These are missing properties used by our layouts in the backend component view classes.

Testing Instructions

Codereview.

Link to documentations

Please select:

  • [ ] Documentation link for docs.joomla.org:

  • [X] No documentation changes for docs.joomla.org needed

  • [ ] Pull Request link for manual.joomla.org:

  • [X] No documentation changes for manual.joomla.org needed

Hackwar avatar Apr 24 '24 20:04 Hackwar

I didn't want to change the base class.

Hackwar avatar May 03 '24 07:05 Hackwar

I would merge it to have to properties defined, maybe adding a note to change the base class with 6

rdeutz avatar Jun 01 '24 14:06 rdeutz

In the meantime I tried using the FormView class instead and it would require major refactoring, which is out of the scope of this PR. Simply switching the base class and removing the properties does not work. Since this PR changes 19 files, this would mean hundreds of complex changes to those 19 files and is not testable anymore. We should be looking at refactoring this accordingly in other PRs, but for this PR it would be out of scope.

Hackwar avatar Jun 01 '24 15:06 Hackwar

Thanks!

laoneo avatar Aug 13 '24 11:08 laoneo