joomla-cms icon indicating copy to clipboard operation
joomla-cms copied to clipboard

[5.2] Adding bootstrap.rtl.css file

Open Hackwar opened this issue 1 year ago • 1 comments

Pull Request for Issue #42653 .

Summary of Changes

In the linked issue, the user complained that the rtl stylesheet is missing from our media folder. This PR adds that file. I'm not sure if it is necessary, but here it is.

Testing Instructions

Run npm i in your git checkout.

Actual result BEFORE applying this Pull Request

There is neither a media/vendor/bootstrap/css/bootstrap.rtl.css nor a media/vendor/bootstrap/css/bootstrap.rtl.min.css file present.

Expected result AFTER applying this Pull Request

The two above files have been generated.

Link to documentations

Please select:

  • [ ] Documentation link for docs.joomla.org:

  • [X] No documentation changes for docs.joomla.org needed

  • [ ] Pull Request link for manual.joomla.org:

  • [X] No documentation changes for manual.joomla.org needed

Hackwar avatar Mar 24 '24 12:03 Hackwar

Unfortunately this is not enough. You woudl also need to add the rtl variants of the other files and the complete set of files for bootstrap-utilities.

brianteeman avatar Apr 02 '24 21:04 brianteeman

I'm closing this PR, since it indeed would require more than this small change.

Hackwar avatar Nov 22 '24 20:11 Hackwar