joomla-cms
joomla-cms copied to clipboard
[4.4] mod_tags_similar: fix of missing core_images field
Pull Request for Issue # .
Summary of Changes
Adding (back) a missing field to the TagsSimilarHelper::getList method Somehow this field removed over time from resultset, however it's a pretty useful and an easy, non-breaking change. when showing com_content items based on tags
Testing Instructions
call TagsSimilarHelper::getList
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Resultset will also contain "core_images" field beside "core_params"
Link to documentations
Please select:
-
[ ] Documentation link for docs.joomla.org:
-
[ ] No documentation changes for docs.joomla.org needed
-
[ ] Pull Request link for manual.joomla.org:
-
[ ] No documentation changes for manual.joomla.org needed
Does the same change have to be made to mod_tags_popular?
Does the same change have to be made to mod_tags_popular?
As i see, mod_tags_popular uses a different query structure, more focused on the tag itself, leaving core content behind. It could be done though, but IMHO it would require much more effort than this two-liner low hanging fruit.
call TagsSimilarHelper::getList
@lorenzods can you give more information how to test?
This pull request has been automatically rebased to 5.2-dev.
This pull request has been automatically rebased to 5.3-dev.
This pull request has been automatically rebased to 5.4-dev.