joomla-cms icon indicating copy to clipboard operation
joomla-cms copied to clipboard

[4.4] mod_tags_similar: fix of missing core_images field

Open lorenzods opened this issue 1 year ago • 3 comments

Pull Request for Issue # .

Summary of Changes

Adding (back) a missing field to the TagsSimilarHelper::getList method Somehow this field removed over time from resultset, however it's a pretty useful and an easy, non-breaking change. when showing com_content items based on tags

Testing Instructions

call TagsSimilarHelper::getList

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Resultset will also contain "core_images" field beside "core_params"

Link to documentations

Please select:

  • [ ] Documentation link for docs.joomla.org:

  • [ ] No documentation changes for docs.joomla.org needed

  • [ ] Pull Request link for manual.joomla.org:

  • [ ] No documentation changes for manual.joomla.org needed

lorenzods avatar Dec 12 '23 11:12 lorenzods

Does the same change have to be made to mod_tags_popular?

brianteeman avatar Dec 12 '23 14:12 brianteeman

Does the same change have to be made to mod_tags_popular?

As i see, mod_tags_popular uses a different query structure, more focused on the tag itself, leaving core content behind. It could be done though, but IMHO it would require much more effort than this two-liner low hanging fruit.

lorenzods avatar Dec 13 '23 07:12 lorenzods

call TagsSimilarHelper::getList

@lorenzods can you give more information how to test?

ghost avatar Aug 28 '24 08:08 ghost

This pull request has been automatically rebased to 5.2-dev.

HLeithner avatar Nov 15 '24 13:11 HLeithner

This pull request has been automatically rebased to 5.3-dev.

HLeithner avatar Apr 15 '25 16:04 HLeithner

This pull request has been automatically rebased to 5.4-dev.

HLeithner avatar Oct 15 '25 17:10 HLeithner