[4.4] Update tag router to restrict lossy matches to menu items set to any

[shane-clickingmad]

Pull Request for Issue #40750 .

Summary of Changes

Only populate the menu items into $this->lookup if they are a direct match, or return_any_or_all is set to any.

Testing Instructions

Setup two tags. Setup a menu item point to a singular tag Setup a second menu item pointing to both tags, match type All Populate articles into the first tag to show pagination within page (can change global config list limit to 5 to make this easier) Navigate to the first menu item on the front end. Observe pagination links

Actual result BEFORE applying this Pull Request

Pagination URL incorrectly pointing to second menu item (with multiple tags selected), instead of the current menu item. Page: /tag-1 pagination link: /tag-1-and-2?start=5

Example: Page: /tag-1 pagination link: /tag-1?start=5

Expected result AFTER applying this Pull Request

Pagination URL's now correctly paginate through the current menu item.

Example: Page: /tag-1 pagination link: /tag-1-and-2?start=5

Link to documentations

Please select:

• [ ] Documentation link for docs.joomla.org:

• [x] No documentation changes for docs.joomla.org needed

• [ ] Pull Request link for manual.joomla.org:

• [x] No documentation changes for manual.joomla.org needed

[exlemor]

Hi @shane-clickingmad, I tried to follow your testing instructions step by step but I think something is missing as it did not yield what was supposed to be happen ;-(

Can you please check them so that I can test it again very soon.

(sorry)

[ghost]

I have tested this item :white_check_mark: successfully on e0023c944d96210622d5b311fdae1b2cf0cbcfd3

Without patch	With patch
Pagination URL show "menutwotags"	Pagination URL show "menuonetag"

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42162.}

[HLeithner]

This pull request has been automatically rebased to 5.2-dev.

[HLeithner]

This pull request has been automatically rebased to 5.3-dev.

[drmenzelit]

I have tested this item :white_check_mark: successfully on 4d1d589e484d1dc78b6464e4e20bbd14b70c32c3

Before: /tag-pbf /tags/pbf?start=5

After: /tag-pbf /tag-pbf?start=5

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42162.}

[obuisard]

I have tested this item :white_check_mark: successfully on 4d1d589e484d1dc78b6464e4e20bbd14b70c32c3

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42162.}

[richard67]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42162.}

[rdeutz]

Thanks