[5.0] Enhance translation "Empty trash"

[chmst]

Pull Request for Issue #41106 . Replacement of #41116.

Summary of Changes

Replace the text "Empty trash" as proposed in #41106.

Testing Instructions

Check a trash can before and after patch

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

• [ ] Documentation link for docs.joomla.org:

• [x] No documentation changes for docs.joomla.org needed

• [ ] Pull Request link for manual.joomla.org:

• [x] No documentation changes for manual.joomla.org needed

[Quy]

Is Permanently necessary? See under Users, Media, Smart Search where the button is Delete only?

[chmst]

TBH - I have no opinion here, only want to get rid of the "empty trash". Agree that we say only "delete" in other cases. Would bee nice to get a few opinions.

[brianteeman]

I am not too concerned about the selection. For me there is nothing wrong with the current text.

We put items in the trash (by changing the state) Then we empty the trash.

That is the same language construct used in windows

[chmst]

Speaking for me: When I empty a bin, I empty it completely, I don't pick out single items. This is why I would prefer the word "delete". This is a UX thing, maybe @crystalenka s team can help.

Edit:

That is the same language construct used in windows

Windows does what I use to do with the bin "empty trash" == Empty completely.

[Quy]

Delete implies permanent so no need to mention it. See menu options when deleting a file in the recycle bin.

[chmst]

Interesting feature :) Changing the language string to "delete" is easy, of course. But it is not the best solution. Because in users or menus we have the "delete" in the action dropdown.

If we are following the windows behaviour we must have: The "empty trash" button which then really deletes the whole trash (after message "do you really want..." ) and a delete button in the action drop down menu.

This is a big action, as all our backend views are concerned.

[brianteeman]

This is a big action, as all our backend views are concerned.

Which is why its never been done before. it is also a potentially big b/c break for 3pd

[HLeithner]

For me the problem is not the text, instead the way to get there, 9 clicks to delete an item is the problem not if it's called "empty trash" or "delete" or "burn it down the house".

Edit: it's 9 clicks instead of 7

[brianteeman]

suggestions

remove the requirement to select an item before the empty trash button is active. if nothing is selected then everything is deleted. if something is selected then just delete the selected items

remove the "are you sure" confirmation. going from published to trashed should be enough of an opportunity to change your mind without being asked again

[HLeithner]

Additional to brians suggestions: Add a button to go directly to the trash filter and allow "shift" + "trash button" to directly delete items (like any system allows this) and change the text if shift button is hold down.

[chmst]

@HLeithner fully agree. I would like a quick icon "thrash" in the dashboard which allows managing all trash in one step - like global checkin. This would be self explaining also for newbies.

But not in scope here :)

[brianteeman]

I would like a quick icon "thrash" in the dashboard which allows managing all trash in one step - like global checkin.

I tried to write that some time ago but my code was not good.

Additional to brians suggestions: Add a button to go directly to the trash filter and allow "shift" + "trash button" to directly delete items (like any system allows this) and change the text if shift button is hold down.

if that is possible then great - not something I have seen in a web ui before

[chmst]

allow "shift" + "trash button" to directly delete items (like any system allows this) and change the text if shift button is hold down.

This is a developer solution but I am advocate of normal users, I doubt if this is self-explaining and a11y ?

[HLeithner]

if that is possible then great - not something I have seen in a web ui before

it's basically the same as the joomla shortcuts, something like this:

document.querySelector('body').addEventListener("keydown", (e) => {      
  if (e.key === "Shift") {
    result.innerText = "Shift Key Pressed";
  }
});

document.querySelector('body').addEventListener("keyup", (e) => {      
  if (e.key === "Shift") {
    result.innerText = "Shift Key Not Pressed";
  }
});

[HLeithner]

allow "shift" + "trash button" to directly delete items (like any system allows this) and change the text if shift button is hold down.

This is a developer solution but I am advocate of normal users, I doubt if this is self-explaining and a11y ?

you can explain it in a guided tour, but it's also only an additonal way

[brianteeman]

Removing the "are you sure" is a simple one line change in each component for example delete this line https://github.com/joomla/joomla-cms/blob/c944137dc9c6461290d4631f2b3242dc107dab93/administrator/components/com_content/src/View/Articles/HtmlView.php#L231

Making the button deleteAll without having selected anything is a bigger change as that is in the library

[coolcat-creations]

I love this PR, It confuses so much of my customers that its called Empty trash but does not do it

[HLeithner]

Changing the meaning of a language string is a b/c break and not allowed at all per policy if we like to use "Delete" as string instead of "Empty Trash" then we need a new language string and use this one. Also "Delete Permanently" is redundant language as mentioned by @Quy

[HLeithner]

This pull request has been automatically rebased to 5.1-dev.

[RickR2H]

I have tested this item :white_check_mark: successfully on 500df900a1cd4d00fe3bd3c2abd5dbc4f304ea20

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41119.}

[viocassel]

I have tested this item :white_check_mark: successfully on 500df900a1cd4d00fe3bd3c2abd5dbc4f304ea20

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41119.}

[richard67]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41119.}

[brianteeman]

This should not be RTC

1. @HLeithner points out that changing the meaning of a language stribg is a b/c break
2. @quy points out that "permanently" is a redundant word. You can'd delete something unpermanently

[richard67]

Back to pending

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41119.}

[HLeithner]

Yes please create a new translation string, and make it simple, maybe use "Nuke" ;-)

[paternax]

I have tested this item :white_check_mark: successfully on 500df900a1cd4d00fe3bd3c2abd5dbc4f304ea20

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41119.}

[fgsw]

I have tested this item :white_check_mark: successfully on 500df900a1cd4d00fe3bd3c2abd5dbc4f304ea20

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41119.}

[tecpromotion]

Yes please create a new translation string, and make it simple, maybe use "Nuke" ;-)

@chmst is that still up to date? Any plans for 5.1?

[Quy]

Maybe do it like Clear Cache. Add Delete and either keep Empty Trash or change to Delete All.

[crimle]

I have tested this item :white_check_mark: successfully on 500df900a1cd4d00fe3bd3c2abd5dbc4f304ea20

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41119.}