joomla-cms icon indicating copy to clipboard operation
joomla-cms copied to clipboard

Less is more: Configure Options

Open chmst opened this issue 3 years ago • 4 comments

Pull Request for Issue # .

Summary of Changes

"Configure Options Only" makes me think .. why only?

grafik

Change the String to "Configure Options"

chmst avatar Sep 18 '22 10:09 chmst

I have tested this item :white_check_mark: successfully on 125143e1467004884d98ac32501d5ca0867562cc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38781.

ChristineWk avatar Sep 18 '22 11:09 ChristineWk

Not at my pc but please check template manager. Iirc this string comes from there where you could have access to options but not other restricted items. Unlike all other components

brianteeman avatar Sep 18 '22 11:09 brianteeman

The string is used in permissions of the template manager. But still correct when the "only" is removed.

If core.options has another meaning in template management than in other components, we better should define an specified action.

grafik

chmst avatar Sep 18 '22 12:09 chmst

Now that I am at my pc I can see that what was originally just a template manager permission is now everywhere and that the problem is not so much the word "only" but that there is a column missing in the users permissions view. "Configure ACL and Options"

brianteeman avatar Sep 19 '22 09:09 brianteeman

Looking at the issue I just created #38830 I can see that the problem here arises from your pr #37807 which moved core.admin (Configure ACL and Options) out of the columns but did not also move core.options (Configure ACL Only)

In summary this is not the correct fix and it should be fixed together with #38830

brianteeman avatar Sep 24 '22 08:09 brianteeman

Will check after my holidays. The problem occurs if no permissions are found on level >= 4.

chmst avatar Sep 25 '22 21:09 chmst

Looking at the issue I just created #38830 I can see that the problem here arises from your pr #37807 which moved core.admin (Configure ACL and Options) out of the columns but did not also move core.options (Configure ACL Only)

In summary this is not the correct fix and it should be fixed together with #38830

https://github.com/joomla/joomla-cms/issues/38830 is resolved with https://github.com/joomla/joomla-cms/pull/38960. PR https://github.com/joomla/joomla-cms/pull/37807 did not import a bug but made an old error visible. In summary this issue has nothing to do with the above PRs.

chmst avatar Oct 16 '22 07:10 chmst

Sorry for mistaking that error.

While I agree that in the debug user permissions view it might not be needed removing it from the permissions table does change its meaning.

image

brianteeman avatar Oct 16 '22 07:10 brianteeman

I don't insist in changing the label, but I see a logical error in the permission rules. As a user and only from labels I think:

Configure everything | Configure options only | result

     yes         |       yes               |   configure everything but for what do we need  options only?
     yes         |       no                |   configure eeryting but don't configure options only (!)
     no          |       yes               |   configure nothing but configure options only (!)
     no          |       no                |   configure nothing but for what do we need  options only?

The follwing would be correct but must be checkd in the whole core


Configure ACL | Configure options       | result
-----------------------------------------------------------------
         yes  |       yes               | configure everything
         yes  |       no                | configure ACL only 
         no   |       yes               | configure options only
         no   |       no                | configure nothing

chmst avatar Oct 16 '22 09:10 chmst

There isn't a configure acl only option

(maybe there should be)

brianteeman avatar Oct 16 '22 10:10 brianteeman

This is what I wanted to demonstrate. Configure ACL and Configure Options would be better. But this is a bigger task and surely not for J4.

chmst avatar Oct 16 '22 10:10 chmst

Agreed.

Originally the "configure options only" was a hack for joomla.com in com_templates when it was at siteground iirc

brianteeman avatar Oct 16 '22 10:10 brianteeman

I have tested this item :white_check_mark: successfully on 125143e1467004884d98ac32501d5ca0867562cc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38781.

Quy avatar Jan 19 '23 19:01 Quy

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38781.

Quy avatar Jan 19 '23 19:01 Quy

Thank you

roland-d avatar Jan 20 '23 08:01 roland-d

The change was unfortunately not made consistently in the API. https://github.com/joomla/joomla-cms/blob/4c918795a083cc03a808c02920f7d06093b26b15/api/language/en-GB/joomla.ini#L167

PR #39682 will fix this.

tecpromotion avatar Jan 21 '23 08:01 tecpromotion