joomla-cms icon indicating copy to clipboard operation
joomla-cms copied to clipboard

Removing unnecessary "Table of" from table caption strings.

Open crystalenka opened this issue 3 years ago • 10 comments

Pull Request for Issue #35279 .

Summary of Changes

Screen readers announce the element type by default; if an individual has set their device to not announce element types, that is their choice. Similar to having "image of" in alt text or "link to" in a link.

See https://russmaxdesign.github.io/accessible-forms/accessible-name-table04.html for how different screen readers handle table captions by default.

Testing Instructions

With your favorite screenreader, navigate to any core component table view and listens how it announces the table.

Actual result BEFORE applying this Pull Request

VoiceOver

Chrome: Table of [component]. Table. 2 Columns. 3 rows. Firefox: Table of [component]. Table. 2 Columns. 3 rows. Safari: Table of [component]. Table. 2 Columns. 3 rows.

NVDA

Chrome: Table with 3 rows and 2 columns. Table of [component]. Firefox: Table with 3 rows and 2 columns. Table of [component]. Safari: Table with 3 rows and 2 columns. Table of [component].

JAWS

Chrome: Table with 2 columns and 3 rows. [Name not announced] Firefox: Table with 2 columns and 3 rows. [Name not announced] Safari: Table with 2 columns and 3 rows. [Name not announced]

Expected result AFTER applying this Pull Request

VoiceOver

Chrome: [component]. Table. 2 Columns. 3 rows. Firefox: [component]. Table. 2 Columns. 3 rows. Safari: [component]. Table. 2 Columns. 3 rows.

NVDA

Chrome: Table with 3 rows and 2 columns. [component]. Firefox: Table with 3 rows and 2 columns. [component]. Safari: Table with 3 rows and 2 columns. [component].

JAWS

Chrome: Table with 2 columns and 3 rows. [Name not announced] Firefox: Table with 2 columns and 3 rows. [Name not announced] Safari: Table with 2 columns and 3 rows. [Name not announced]

Documentation Changes Required

None that I'm aware of. Perhaps in developer documentation regarding accurate table captions

crystalenka avatar Sep 14 '22 13:09 crystalenka

Missed. Please make corrections.

administrator\language\en-GB\com_contenthistory.ini COM_CONTENTHISTORY_COMPARE_CAPTION="Table comparing two versions."

administrator\language\en-GB\com_scheduler.ini COM_SCHEDULER_TABLE_CAPTION="Tasks List"

language\en-GB\com_contact.ini COM_CONTACT_TABLE_CAPTION="Table of Contacts"

language\en-GB\com_content.ini COM_CONTENT_ARTICLES_TABLE_CAPTION="Table of Articles" COM_CONTENT_CATEGORY_LIST_TABLE_CAPTION="List of articles in category %s"

language\en-GB\joomla.ini JGLOBAL_REPEATABLE_FIELDS_TABLE_CAPTION="Table of repeatable fields."

Kostelano avatar Sep 14 '22 14:09 Kostelano

Thanks @Kostelano , added those and a couple others I missed originally. Nice catch!

crystalenka avatar Sep 15 '22 05:09 crystalenka

I have tested this item :white_check_mark: successfully on 7c4e32fca94d596ab711dbc17123242d5d4b0c25


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38761.

Kostelano avatar Sep 15 '22 10:09 Kostelano

I have tested this item :white_check_mark: successfully on caddbf8860963c0fe1f1e5e53aef8b8d7fe09b84

Because of the latest commit.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38761.

Kostelano avatar Sep 15 '22 10:09 Kostelano

I have tested this item :white_check_mark: successfully on caddbf8860963c0fe1f1e5e53aef8b8d7fe09b84


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38761.

viocassel avatar Sep 15 '22 11:09 viocassel

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38761.

richard67 avatar Sep 15 '22 11:09 richard67

Sorry this is not correct api/joomla.ini is supposed to be in sync with the main joomla.ini

brianteeman avatar Sep 15 '22 12:09 brianteeman

Back to pending. @crystalenka Could you check @brianteeman 's comment above and adjust the api/joomla.ini file, too? Thanks in advance.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38761.

richard67 avatar Sep 15 '22 12:09 richard67

There are other differences between api/joomla.ini and the main joomla.ini. Is there a standard that determines which items carry over and which ones do not?

crystalenka avatar Sep 15 '22 13:09 crystalenka

There are other differences between api/joomla.ini and the main joomla.ini. Is there a standard that determines which items carry over and which ones do not?

@crystalenka Which "main joomla.ini" did you check? As far as I know - but I might be wrong - the api file should be equal to the admin file.

richard67 avatar Sep 15 '22 13:09 richard67

@richard67 that is correct

brianteeman avatar Sep 27 '22 19:09 brianteeman

@brianteeman @richard67 I think there was only one in the main joomla.ini. If I missed any other ones please let me know, but I think it's ready now.

crystalenka avatar Oct 10 '22 12:10 crystalenka

I have tested this item :white_check_mark: successfully on f38dbe294e784c55067091ee67e68d888b22ced2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38761.

Kostelano avatar Oct 10 '22 12:10 Kostelano

I have tested this item :white_check_mark: successfully on f38dbe294e784c55067091ee67e68d888b22ced2

Code Review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38761.

chmst avatar Oct 10 '22 18:10 chmst

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38761.

chmst avatar Oct 10 '22 18:10 chmst

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38761.

richard67 avatar Oct 10 '22 18:10 richard67

Thank you.

roland-d avatar Oct 20 '22 14:10 roland-d