joomla-cms icon indicating copy to clipboard operation
joomla-cms copied to clipboard

logout getMenuLanguage

Open thalueng opened this issue 3 years ago • 3 comments

Steps to reproduce the issue

PHP throws a TypeError on logout from the site. This is because getMenuLanguage is called with the wrong argument in com_users/src/Controller/UserController.php within method logout on line 146 (Joomla 4.2.2), which was introduced with Joomla 4.2.0.

Expected result

getMenuLanguage needs to be called with $return == menu id (xxx) as int, not with $return == 'index.php?Itemid=xxx'

Actual result

System information (as much as possible)

Joomla 4.2.2, Apache 2.4, PHP 7.4

Additional comments

thalueng avatar Sep 08 '22 07:09 thalueng

This is the pull request where the change was made https://github.com/joomla/joomla-cms/pull/38299

brianteeman avatar Sep 08 '22 07:09 brianteeman

Closing as there is a pull request

chmst avatar Sep 11 '22 11:09 chmst

@chmst I think you may have misunderstood. The PR I referenced is the one causing the reported broken behaviour

brianteeman avatar Sep 11 '22 11:09 brianteeman

PR https://github.com/joomla/joomla-cms/pull/39251 should fix this issue. Please help testing. Thanks !

joomdonation avatar Nov 19 '22 11:11 joomdonation