Language Override space

[brianteeman]

When you have a language override that is in both locations then it is displayed as site /administrator

This extra space is added because the markup is on multiple lines.

To Test

Go to language overrides and select a language-admin pair Create a new override and check the box for both locations Save and check the list of overrides

Before

After

[brianteeman]

@HLeithner my reading of the drone error is that its not possible to resolve the space issue that the pr is intended to do without breaking the cs rules. Your advice please

[richard67]

@HLeithner my reading of the drone error is that its not possible to resolve the space issue that the pr is intended to do without breaking the cs rules. Your advice please

@brianteeman Does it work without the curly brackets?

[brianteeman]

Thank @HLeithner all good now

[Kostelano]

I have tested this item :white_check_mark: successfully on b4fee5f17917ccc8409c37589042f4da48e06f31

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38626.}

[viocassel]

I have tested this item :white_check_mark: successfully on b4fee5f17917ccc8409c37589042f4da48e06f31

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38626.}

[richard67]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38626.}

[laoneo]

Should we not try to avoid multi line PHP statements in layout files? If I remember correctly every PHP code in these layout files should start with <?php. To solve this issue you can make a one line statement out of it:

<?php echo $client . (isset($oppositeStrings[$key]) && $oppositeStrings[$key] === $text ? '/' . $oppositeClient : ''); ?>

[brianteeman]

is it in the code styles?

[brianteeman]

... and I would say it is beyond the scope of this PR as it was already on multiple lines that did not begin and end with <?

[HLeithner]

thanks

[brianteeman]

thx