joomla-cms
joomla-cms copied to clipboard
joomla
[5.2] Drone: Adding check for PHP version
Right now we actually aren't checking the compatibility of our code for a certain PHP version statically. This PR should change that.
When PRs #38528 and #38527 are merged, the hard errors would be solved in our codebase. The issues left would be several warnings and 3 errors regarding soft reserved keywords which we are using. Those issues couldn't be solved and should be part of the exclusion list.
@Hackwar what can we do here? clean the error or mark as exception for phpcs?
Most of these should be fixed. Some would have to be marked as exclusions. Will look at that soon.
This needs a thorough code review. All changes are outdated code which we never removed.
Either this needs to be split into chunks with propper teating instructions or rebased to 5.0 and merged there early. But I wouldn't merge this in a minor only by code review.
Please proper error handling using error_get_last() like used in the framework package and rebase on j5.
I've split this PR up into 5 PRs, see above. When those are merged and they are upmerged into this branch, that should leave only the code to introduce the version check in phpcs. I don't think it is usefull to solve the conflicts before those are merged, since each will introduce new conflicts...
Is anything happening with this? It has not been touched for over a year and it is unclear if anything will ever happen. It refers to it being partialy split into 5 pr but some of those have been closed as abandoned.
