joomla-cms icon indicating copy to clipboard operation
joomla-cms copied to clipboard

Published 20 hours ago • verified publisher icon joomla

Activate all unit tests as default

Open laoneo opened this issue 3 years ago • 4 comments

Activates the extension unit tests as default and does remove some deprecated messages in the tests.

Before the pr

image

After the pr

image

laoneo avatar Aug 08 '22 12:08 laoneo

Please add more information to your issue. Without test instructions and/or any description we will close this issue within 4 weeks. Thanks.
This is an automated message from the J!Tracker Application.

joomla-cms-bot avatar Aug 08 '22 12:08 joomla-cms-bot

Thanks for checking this. I doubt that we can merge this without fixing the tests first.

Hackwar avatar Aug 08 '22 12:08 Hackwar

@laoneo see https://github.com/Digital-Peak/joomla-cms/pull/27 for missing namespaces

heelc29 avatar Aug 08 '22 19:08 heelc29

@Hackwar can you have a look on this pr, as it is ready now?

laoneo avatar Aug 09 '22 15:08 laoneo

Think the merge through has gone wrong. You've lost an entire plugin here :)

wilsonge avatar Aug 15 '22 09:08 wilsonge

When 4.3 is up to date, then the pr should be fine again. Do you mean this plugin https://github.com/joomla/joomla-cms/pull/38421/commits/31a2677816a22da4d3f6d831a919efed9b93a139?

laoneo avatar Aug 15 '22 09:08 laoneo

Thank you @laoneo for the PR

obuisard avatar Aug 25 '22 15:08 obuisard