joomla-cms icon indicating copy to clipboard operation
joomla-cms copied to clipboard

[4.3] Input field direction RTL

Open brianteeman opened this issue 3 years ago • 1 comments

I am submitting this as a new feature but it could also be considered a bug fix.

Summary of Changes

If a document is in LTR then all input fields are LTR and vice versa for RTL.

However there are several types of data that should always be LTR such as urls, email addresses and telephone numbers (https://rtlstyling.com/posts/rtl-styling#form-inputs).

For a field type of url, email and tel we can add this to the layout.

However we often use the field type of text for urls eg the custom url for joomla updates this pr also adds the ability to add dir=ltr to the xml definition of a field.

There are also some instances where the field is defined completely in the php so the direction needs to be set there as well.

Testing Instructions

complete the three tests below in both an ltr and rtl language

1. Test the url layout

Enter a link into the Click URL field of a banner The inputting and display of the link should always be ltr

2. Test the direct input

Enter a link into the Install from URL field in the web installer The inputting and display of the link should always be ltr The placeholder text will also be LTR

3. Test the xml field

Enter a link to the Custom Url field of the joomla update The inputting and display of the link should always be ltr

Current Output

1. Test the url layout

image

2. Test the direct input

image

image

3. Test the xml field

image

Expected Output with this PR

1. Test the url layout

image

2. Test the direct input

image

image

3. Test the xml field

image

brianteeman avatar Aug 02 '22 16:08 brianteeman

update to trigger drone

brianteeman avatar Aug 09 '22 15:08 brianteeman

update to trigger drone again

brianteeman avatar Nov 23 '22 11:11 brianteeman

Include the following:

batch-update

Quy avatar Jan 25 '23 18:01 Quy

resolve conflicts caused by change to array codestyle

brianteeman avatar Mar 01 '23 10:03 brianteeman

This pull request has been automatically rebased to 5.0-dev. No new features will be merged into Joomla! 4.3 series. Joomla! 4.4 series is a bridge release to make migration from Joomla! 4 to 5 as smooth as possible.

HLeithner avatar May 08 '23 15:05 HLeithner