joomla-cms icon indicating copy to clipboard operation
joomla-cms copied to clipboard

[4.1] Using languagecode system parameters to display lang tag in assoc badges

Open infograf768 opened this issue 3 years ago • 4 comments

Solving https://github.com/joomla/joomla-cms/issues/37228#issuecomment-1066058545

Summary of Changes

Checking in each case if the language code plugin is enabled and if so, modify the associations badges to use the lang tag defined by the plugin.

Testing Instructions

Create a multilingual site. Enable the languagecode system plugin and give a new lang tag value for a language.

Example: Screenshot 2022-03-16 at 11 29 48

Expected result AFTER applying this Pull Request

Every occurrence of a badge displaying the installed language tag will display the new tag.

Screenshot 2022-03-16 at 11 31 48 Screenshot 2022-03-16 at 11 33 07 Screenshot 2022-03-16 at 11 34 47
  • com_associations, com_contact, com_categories, com_menus, com_newsfeeds

infograf768 avatar Mar 16 '22 10:03 infograf768

Maybe it should be rebased to 4.2-dev because it’s some kind of new feature? If so, I will help if necessary e.g. if JM has little time.

richard67 avatar Mar 19 '22 14:03 richard67

@richard67 Please do whatever is better.

infograf768 avatar Mar 20 '22 08:03 infograf768

This pull request has automatically rebased to 4.2-dev.

HLeithner avatar Jun 27 '22 13:06 HLeithner

This pull requests has been automatically converted to the PSR-12 coding standard.

joomla-bot avatar Jun 27 '22 21:06 joomla-bot

This pull request has been automatically rebased to 5.0-dev.

HLeithner avatar May 02 '23 16:05 HLeithner

Not sure about this. With the patch applied I see the language tag I entered in the Articles list. But I don't see any language tags in the Menus Dashboard or in the admin Main Menu. The html tags contains the tag I entered <html lang="de-ch" dir="ltr">. Is this is a valid test.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37289.

ceford avatar Sep 14 '23 15:09 ceford

@ceford this is a pr with merge conflicts that prevent testing

image

brianteeman avatar Sep 14 '23 16:09 brianteeman

This pull request has been automatically rebased to 5.1-dev.

HLeithner avatar Sep 30 '23 22:09 HLeithner

This pull request has been automatically rebased to 5.2-dev.

HLeithner avatar Apr 24 '24 09:04 HLeithner