[4.2] The alias is already being used - updates

[brianteeman]

pr for #37013

create a menu item called test Try to create a second menu item also called test

Before

After

It only says trashed if it is trashed and the link opens the existing menu item

Plus

Also updates com_content, com_categories, com_newsfeeds by splitting the message into two (one if the item is trashed). These are simpler changes as they dont have item names or links

Also updates com_finder filters to use a correct language string. Its not an article and it cant be trashed ;)

com_banners has not been updated because there is an existing bug in that #37031

[HLeithner]

You have to use a new language string else we get a fatal error without of sync languages

[brianteeman]

You have to use a new language string else we get a fatal error without of sync languages

no you don't. Did you actually test it? If you did and you got a fatal error please post the stack trace.

[ChristineWk]

Patch activated: The patch could not be applied because it conflicts with a previously applied patch: administrator/language/en-GB/lib_joomla.ini (4.1.0-rc5-dev)

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37017.}

[brianteeman]

I assume thats with patchtester? You cannot apply a patch on to an existing one. You need to rest first.

[ChristineWk]

Of course have fetched before. And now resetted. Will try again.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37017.}

[ChristineWk]

I have tested this item :white_check_mark: successfully on 834c85c06c55854aa078f1aac9e8853abc48b5bc

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37017.}

[ChristineWk]

Result:

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37017.}

[chmst]

@brianteeman I see a chance to improve this message (as i have monochrome in backend I tried to cklick on all strong parts of the text).

What do you think about

where the string trashed is set only if the item is trashed?

[brianteeman]

@chmst oh there are lots of possibilities for improvement. My main concern at this moment in time is if the code is correct.

[brianteeman]

@chmst unless I am very much mistaken the change to have two strings - one for trashed and one for regular items - is very easy. It was just lazy coding before to have that language string.

Once @HLeithner can confirm that he was wrong I will continue to work on this.

[chmst]

@brianteeman yes, otherwise it would be tricky. If the user has a link, he can see that the item ist trashed, so maybe it is not necessary to mention it at all

[brianteeman]

@chmst updated the PR so that the message is different if the duplicate is trashed or not

[brianteeman]

Updated as requested by @roland-d

[joomla-bot]

This pull requests has been automatically converted to the PSR-12 coding standard.

[obuisard]

@roland-d are you planning to include this PR into 4.2? Not sure if language files are updated on minor releases.

[zero-24]

Not sure if language files are updated on minor releases.

That should not be a blocker for things merged into 4.2 :)

[brianteeman]

Is this ever going to be merged?

[roland-d]

Thanks

[brianteeman]

thanks