joomla-cms
joomla-cms copied to clipboard
joomla
[4.2] Enable automatic title for admin modules
Pull Request for Issue https://github.com/joomla/joomla-cms/issues/35587 (partly) Related to https://github.com/joomla/joomla-cms/pull/21330
Summary of Changes
Make sure automatic title is enabled by default like we had it in 2.5
Testing Instructions
Install package build for this PR by dron and confirm that the setting Automatic Title is enabled for Popular Articles, Recently Added Articles, Logged-in Users and Latest Actions.
Actual result BEFORE applying this Pull Request
The setting is disabled and just the original title is displayed.
Expected result AFTER applying this Pull Request
The setting is enabled and shows the generated title instead of the default.
Documentation Changes Required
@wojsmol Could you refer to the right issue #35587 instead of the duplicate #35820 ? Thanks in advance.
@richard67 This PR fixes https://github.com/joomla/joomla-cms/issues/35587 only partially for modules witch have automatic title support.
@richard67 This PR fixes #35587 only partially for modules witch have automatic title support.
@wojsmol Then you should have written something like „Pull request for issue #35587 (partly)“ at the top of your PR. It causes us additional work to sort out which issues to close or not to close it people don’t properly refer to issues in their PRs.
#21330
Yes thats why we first asked the 4.2 release leads and they signaled us that such a PR would be accepted into 4.2 to improve non-english backends. This PR is only changing it for new installations so existing installations are still working as they do now. :)
#21330
Yes thats why we first asked the 4.2 release leads and they signaled us that such a PR would be accepted into 4.2 to improve non-english backends. This PR is only changing it for new installations so existing installations are still working as they do now. :)
And someone was to know that how? Mind-reading?
This PR is incomplete. There is zero point in just having a few modules in the admin language. If you're going to do this then do it properly and make sure that all the modules etc have automatic titles.
Also please move the switch to use the automatic titles to the main tab. Otherwise we will have users (once again) who dont understand why none of the changes they make to the module titles work.
I have tested this item :red_circle: unsuccessfully on 4666c9520c98986b428b558cd04eb9d8603bc2dc
This breaks(?) all existing sites.
On an existing site the installation sql did not add the default value of automatic_title=0 which was not really a problem as it matched the default settings in the module xml
However this PR changes all of that.
On an existing site - apply this PR. There is no visible change and modules still use the natural title Open any article for editing and you will be confused as it will show that automatic titles are being used - they're not Open any article for editing and change the title and save - now you will be confused as your module is neither using the original title or the title you just set. Instead it will use the automatic title.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36954.
@brianteeman Issue reported in https://github.com/joomla/joomla-cms/pull/36954#issuecomment-1031186853 was fixed in https://github.com/joomla/joomla-cms/pull/36954/commits/799a64a10a7de876ba5b23af8fec4fd723eb2497
@brianteeman I just merged latests 4.2-devf into branch of this PR but tests are still failing.
yes looks like the new sampledata helper is not loaded in the module yet. i was sure i have tested that too but looks like i have not.
yes looks like the new sampledata helper is not loaded in the module yet. i was sure i have tested that too but looks like i have not.
The log shows that installation works well, but then it fails to unpublish the statistics module. Possibly the tests need to be adjusted to a changed module title or something like that? If that is the case, all human tests will work and only the automated tests fail as long as not adapted.
the main problem however with this PR is it is completely non intuitive.
The principle of the pr is a good one but the implementation is wrong. If you look elsehwere in Joomla 4 where we have translatable titles it is much clearer.
As it is right now there is no way that a new user would understand that the title the title of the module Latest Articles can not be changed unless they also turn off the automatic title setting. It just looks like a bad bug that the title never changes no matter what you put in the module.
Take a look at workflows for an example of how it could be done
This pull requests has been automatically converted to the PSR-12 coding standard.
