joomla-cms
joomla-cms copied to clipboard
joomla
[5.2] Remove ExecRuleHelper
Summary of Changes
Replace the ExecRuleHelper class with Task::computeNextExecution().
Testing Instructions
- Creating new tasks and modifying existing tasks works as expected.
- Triggered tasks computer next execution date as expected from configuration.
Actual result BEFORE applying this Pull Request
ExecRuleHelper exists, for little reason.
Expected result AFTER applying this Pull Request
ExecRuleHelper is safely replaced by Task::computeNextExecution()
Documentation Changes Required
-
I applied this patch and tried to change settings of a task:
When saving this settings:
PHP 8.0, win11 and xampp
The removed helper PHP will have to be added to the list of files to be deleted on update in script.php. I will do that when this PR has been merged.
@ditsuke I think @chmst indeed found an issue with your changed code, possibly here: https://github.com/joomla/joomla-cms/pull/36439/files#diff-b9f75ae33fad36d7a8968d12a2b78ec972c5e6d2c6fd7ed0024d764191ec48ecR572 .
Possibly a type cast to object is not sufficient. I don't have looked up now what the constructor expects.
@chmst @richard67 thanks for identifying the issue and the source! The latest commit should solve it. Please test.
You fixed the code error, but I don't understand why the Task Params are twice. First in tab "New Task" and in tab "Advanced"?
You fixed the code error, but I don't understand why the Task Params are twice. First in tab "New Task" and in tab "Advanced"?
@chmst I addressed that in https://github.com/joomla/joomla-cms/pull/36515 (needs test). We need the routine parameter fieldset to have a showFront="true" attribute at the moment. Although I don't think that's ideal, this PR should work for now. Let's try to work on removing this requirement in the future!
@ditsuke this PR is still open. could you please resolve the conflicts so that we can re-test?