joomla-cms icon indicating copy to clipboard operation
joomla-cms copied to clipboard

Usability Issue in Joomla when filter text

Open B3nito opened this issue 5 years ago • 24 comments

Is your feature request related to a problem? Please describe.

When you are a enduser and use an editor and plugin settings is filtering input then html is just stripping out of text.

Describe the solution you'd like

User should get notification that html was cleaning for plugin settings so better usability

Additional context

I have problem in custom fields that filter is enabled default and user thought that Joomla is buggy. User should know what system is do automatically.

B3nito avatar Nov 30 '20 13:11 B3nito

Is this issue still persist?

Ayushsunny avatar Mar 18 '21 07:03 Ayushsunny

i want to solve this issue please guide me

pank1999 avatar Mar 19 '21 04:03 pank1999

I want to solve this issue.

Nitesh639 avatar Mar 23 '21 10:03 Nitesh639

@HLeithner I'd love to work on this issue , can you please assign and guide me ?

Yash-g17 avatar Mar 25 '21 20:03 Yash-g17

The Joomla Project doesn't assign issues to contributors in that way. Just work on it and submit a PR :-)

https://github.com/joomla/joomla-cms/blob/staging/.github/CONTRIBUTING.md

brianteeman avatar Mar 25 '21 20:03 brianteeman

The Joomla Project doesn't assign issues to contributors in that way. Just work on it and submit a PR :-)

https://github.com/joomla/joomla-cms/blob/staging/.github/CONTRIBUTING.md

is there any mentor who can help us to solve this issue?

Ayushsunny avatar Mar 26 '21 04:03 Ayushsunny

I want to solve this issue

abhijha0602 avatar Mar 26 '21 14:03 abhijha0602

Just work on it and submit a PR :-)

ghost avatar Mar 26 '21 14:03 ghost

how can i check this issue in own ?

imtiyaj786 avatar Mar 31 '21 12:03 imtiyaj786

Hello volunteers,

  • You don't have to ask if you are allowed to take over an issue.
    • Identify the issue in an installation of Joomla. Use a nightly build for it: https://developer.joomla.org/nightly-builds.html
    • Try to find a code solution for the issue after you have checked whether it really exists.
    • If it exists confirm it here in the issue for the sake of completeness. A "I'll take over" is a good hint for others that don't waste their time then with it.
    • Test your solution.
    • Finally provide a pull request on GitHub (= "here") that others can test. If tests are not successful you can change and discuss your pull request for further tests.
    • Sometimes others provide a "suggestion" that you can merge directly by clicking in your PR.
  • There are no mentors to accompany you. It goes without saying that you can ask the general public how this or that works. I think (don't know) that the "Discussions" tab above can be a good place for more general questions.
  • Here is a doc how to create pull requests via browser GUI: https://docs.joomla.org/Using_the_Github_UI_to_Make_Pull_Requests
  • If you want to go deeper you could also work with a git repository tool on your local machine. Needs some more skills and time to learn:

ReLater avatar Mar 31 '21 13:03 ReLater

hey @B3nito can you help me with this issue want to contribute to solve it

amankothiyal04 avatar Apr 04 '21 08:04 amankothiyal04

I would like to solve this issue. Can you please guide me.

Shaveetha avatar Apr 08 '21 09:04 Shaveetha

@Shaveetha @amankothiyal04

Hello volunteers,

  • You don't have to ask if you are allowed to take over an issue.
    • Identify the issue in an installation of Joomla. Use a nightly build for it: https://developer.joomla.org/nightly-builds.html
    • Try to find a code solution for the issue after you have checked whether it really exists.
    • If it exists confirm it here in the issue for the sake of completeness. A "I'll take over" is a good hint for others that don't waste their time then with it.
    • Test your solution.
    • Finally provide a pull request on GitHub (= "here") that others can test. If tests are not successful you can change and discuss your pull request for further tests.
    • Sometimes others provide a "suggestion" that you can merge directly by clicking in your PR.
  • There are no mentors to accompany you. It goes without saying that you can ask the general public how this or that works. I think (don't know) that the "Discussions" tab above can be a good place for more general questions.
  • Here is a doc how to create pull requests via browser GUI: https://docs.joomla.org/Using_the_Github_UI_to_Make_Pull_Requests
  • If you want to go deeper you could also work with a git repository tool on your local machine. Needs some more skills and time to learn:

brianteeman avatar Apr 08 '21 09:04 brianteeman

Can you please remove the "good first issue label" as its absolutely not a simple thing to fix (not sure if its even possible)

brianteeman avatar Apr 25 '21 11:04 brianteeman

I don't think it's too hard.

I would solve this issue with 5 lines of code (without looking in deep, only looked at com_content)

Adding $original = $text at this position: https://github.com/joomla/joomla-cms/blob/4.0-dev/libraries/src/Component/ComponentHelper.php#L126

And a if ($text !== $original) { JFactory::getApplication()->enqueueMessage('JHTML_FILTER_MODIFY', CMSApplicationInterface::MSG_WARNING); } at line https://github.com/joomla/joomla-cms/blob/4.0-dev/libraries/src/Component/ComponentHelper.php#L295

Of course the language string have to be added too. But maybe I think too simple and missed something ymmv

HLeithner avatar Apr 25 '21 15:04 HLeithner

  1. That won't work for text filtering where the editor eg tinymce is doing the filtering
  2. To be useful it really should say what has been filtered

brianteeman avatar Apr 25 '21 15:04 brianteeman

  1. is not possible (at least I can't think of a working solution)

  2. I'm pretty sure there is a way to achieve this for tinymce in js too

HLeithner avatar Apr 25 '21 15:04 HLeithner

Its still not a "good first issue" which was the point of my post

brianteeman avatar Apr 25 '21 16:04 brianteeman

Why not? it's easy to fix, the first parts are only 5 lines of code.

What would you say what's a good first issue is, If you find one I would really like to tag it.

HLeithner avatar Apr 25 '21 16:04 HLeithner

If it was so easy then any one of the 10 people who said they wanted to fix it would have been able to or anyone else for that matter in the months since november. plus if its really so easy then you would have submitted it instead of debating a pointless argument with me.

brianteeman avatar Apr 25 '21 17:04 brianteeman

@brianteeman Can I work on this ?

teekhandekar avatar Mar 25 '22 04:03 teekhandekar

@brianteeman Can I work on this issue?

adithyareddych avatar Mar 28 '22 04:03 adithyareddych

is this issue still open want to work on it

anshumaan255 avatar Jul 30 '22 07:07 anshumaan255

@anshumaan255 https://github.com/joomla/joomla-cms/issues/31540#issuecomment-811070565

ghost avatar Jul 30 '22 07:07 ghost

Hey,@B3nito Can i work on this issue ?

dv2202 avatar Dec 04 '22 06:12 dv2202

@dv2202 No need to ask. See https://github.com/joomla/joomla-cms/issues/31540#issuecomment-811070565 for more details.

joomdonation avatar Dec 04 '22 07:12 joomdonation

can you please assign me this issue?

YashSalve695 avatar Jan 09 '23 13:01 YashSalve695

i also want to contribute for this one.

kushvahasumit avatar Jan 10 '23 06:01 kushvahasumit

I wanna work on this issue please assign me this issue i would like to contribute in it

farmannaseem avatar Jan 12 '23 10:01 farmannaseem