RTC Labeling Removes All Other Labels

[mbabker]

The RTC behavior should only add/remove that specific label. Whatever is causing all other labels and the milestone to be removed needs to be corrected.

[zero-24]

https://github.com/joomla/jissues/blob/master/src/App/Tracker/Controller/Hooks/Listeners/JoomlacmsPullsListener.php#L330-L351

Maybe this is a permission problem? If you don't have the permissions to change the label / milestones than the labels / milestones got removed.

So i think this could be a problem in the save method where the milestones and labels are empty if you don't have the permissions to change them. This result than in removing them.

[zero-24]

hmm i have just noticed that the issue i'm editing does not contain any labels & milestone on the tracker

But does contain some labels and milestone on github.

So this looks like a bigger problem to me?

[b2z]

@zero-24 may be ;) @mbabker can you please provide DB export of i.j.org to replicate the problem? AFAIK you did it something like this before in other issue. Do not remember, in which :)

[mbabker]

https://issues.joomla.org/uploads/db.zip

[b2z]

@mbabker thanks!

@zero-24 I see that you was able to set labels and milestone. I also tried to edit this issue and it contains labels and milestones. Is it specific case for this issue or it is happening all the time?

I do not think that the permission is the issue here as we display labels only for user with manage rights.

{% if user.check('manage') %}

And this users for sure are those who has permissions. I think the problem was that this issue did not have any label and milestone on the time of your editing. Why? That is the question :)

[zero-24]

I think the problem was that this issue did not have any label and milestone on the time of your editing. Why? That is the question :)

Correct. Maybe the sync job is failing for any reason?

[b2z]

Maybe the sync job is failing for any reason?

Hate to say it, but it seems that it is sync job again :(

[zero-24]

@mbabker do you have any errors or similiar in the logs?

[mbabker]

All the cron logging is telling me is that weblinks and the CMS jobs aren't running in full. Not much has changed since https://github.com/joomla/jissues/issues/915 or https://github.com/joomla/jissues/issues/676 were logged.

[b2z]

Can we close it?

[b2z]

@zero-24 is issue still valid?

[zero-24]

Saddly yes. When you are a user with no persmissions on gihub but just on the tracker and set a item e.g. to RTC all labels expected RTC are removed.

[b2z]

:( I will try to replicate and fix it.

[b2z]

Annoying. @mbabker can you give actual DB state from issues to import? Thank you!