custom-elements icon indicating copy to clipboard operation
custom-elements copied to clipboard

Tabs mobile background

Open bembelimen opened this issue 4 years ago • 5 comments

https://github.com/joomla-projects/custom-elements/blob/master/src/scss/tab/tab.scss#L53

Being in mobile view activating a tab the background becomes semi-transparent:

grafik

Without active everything is ok:

grafik

CC @dgrammatiko

bembelimen avatar Jul 31 '21 05:07 bembelimen

I think it's coming from https://github.com/joomla-projects/custom-elements/blob/1cc751ee7fcf81d6b1e8ce417dee1db35a795a8c/src/scss/tab/tab.scss#L46

dgrammatiko avatar Jul 31 '21 07:07 dgrammatiko

Hey @bembelimen ! Can I work on this issue?

helper-uttam avatar Nov 16 '21 17:11 helper-uttam

Sure

bembelimen avatar Nov 16 '21 18:11 bembelimen

Hey @bembelimen ! Can I work on this issue?

Can you provide me some resource to setup this project into my machine for testing purposes. I have gone through the docs but still not able to set it up.

What I have done-

npm install joomla-ui-custom-elements npm install -g grunt-cli npm install grunt After these installation I am tring to use Joomla custom elements by linking <link href="joomla-alert.min.css" rel="stylesheet"> and <script src="joomla-alert.min.js"></script> to my html file.

helper-uttam avatar Nov 17 '21 03:11 helper-uttam

Can you provide me some resource to setup this project into my machine for testing purposes.

  • clone the repo git clone [email protected]:joomla-projects/custom-elements.git
  • Install npm dependencies npm install
  • Run npm run build to compile js and CSS

Probably you need a server to check the changes, you can have one with this command npx http-server

Before making a PR please lint your code and make sure that tests are still green. All the available command are here: https://github.com/joomla-projects/custom-elements/blob/fd4bbc733de36d13634f634afe3f78870af51e02/package.json#L54-L61

dgrammatiko avatar Dec 08 '21 19:12 dgrammatiko