J4admin updated webcomponents

[sahidhossen]

[C-Lodder]

You're missing the documentation for here: https://joomla-projects.github.io/custom-elements

[sahidhossen]

I have added the documentation in docs folder. Did you check changes ?

[sahidhossen]

Hi @C-Lodder can you check the issue in CI ?

Missing Sauce credentials. Did you forget to set SAUCE_USERNAME and/or SAUCE_ACCESS_KEY? The command "wct --configFile saucelabs.conf.json --plugin sauce" exited with 1.

[C-Lodder]

@sahidhossen i don't have access to the Saucelabs account.

@wilsonge or @dgrammatiko will have those details

[wilsonge]

Variables are superficially there. Updated the key and restored it in travis and have updated the config to the latest travis approved version in their docs. works in the master branch now. So update your branch to master here and see what happens I guess.

Also can we remove the yarn-error log file from here please

[wilsonge]

Just fixed the failures in the build quickly so hopefully we should get green when the branch is updated :)

[wilsonge]

I don't get the failure :( https://travis-ci.org/joomla-projects/custom-elements/builds/607091608#L445 we can see the username is there. Obviously the access key is encrypted so not showing - but it has the same all branches config as the username - and we can see in the master branch it's clearly working.

[sahidhossen]

@wilsonge Is this the reason for the failure?

Encrypted environment variables have been removed for security reasons. See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions

[wilsonge]

Ahh yeah that would do it. They even mention sauce labs as an explicit example there 🤔 . So with travis we can't actually run the sauce lab tests until we've merged the pull request unless you've got write access to the project. Sounds fairly broken :)

[brianteeman]

The following code is not correct because it may result in invalid markup const accordionTitle = document.createElement('h3');

By forcing the title to be a h3 then you can get an h3 directly after an h1 which is a serious accessibility failure

There may be other instances of this error - I just highlighted one as an example

[sahidhossen]

@brianteeman we create h3 tag inside joomla-accordion component and each accordion content always inside a section tag.

But if its a serious accessibility issue then can you suggest alternative solution for this?

For accordion I think we can use div rather than h3 .

[brianteeman]

Yes its a serious accessibility issue so please make it a div AND also check that there are no other places that an Hx is used

[sahidhossen]

Ok I will update in accordion and check other places regarding the issue. Thanks for your suggestion.

[C-Lodder]

The days when H tags were used based on sizing lol

[sahidhossen]

Hi @C-Lodder , If it has no other issue then can you please merge this pull request and run CI ?

[C-Lodder]

I don't have the permissions to merge

[brianteeman]

Oops the code changes I just commented on changing 0px to 0 should of course have been done in the scss file and not the generated css files