Faker.Net icon indicating copy to clipboard operation
Faker.Net copied to clipboard

Published 20 hours ago • verified publisher icon jonwingfield

Names from Senegal West Africa

Open PapePathe opened this issue 13 years ago • 4 comments
trafficstars

PapePathe avatar Oct 01 '12 01:10 PapePathe

Thanks for this pull request! I'll review it and merge shortly

jonwingfield avatar Oct 01 '12 03:10 jonwingfield

Ok i'll be happy. I'm also a contributor in the ruby version. .Net addicted i could not miss this.

PapePathe avatar Oct 01 '12 12:10 PapePathe

Ok, so I've been thinking about this a bit more. How would you feel about something like this:

    Faker.Country = Countries.SN
    Name.LastName // => Biagui

As opposed to having a different class for each country?

I was looking at how ffaker does it in ruby, and they appear to have taken your approach, which would keep it more consistent. However, doing something like the above would really cut down on the amount of code that is needed.

jonwingfield avatar Oct 01 '12 15:10 jonwingfield

+1 for that. I was thinking about this issue but didnt find a solution. Sorry for the late answer.

PapePathe avatar Oct 21 '12 04:10 PapePathe