is-equal-shallow icon indicating copy to clipboard operation
is-equal-shallow copied to clipboard

Published 20 hours ago • verified publisher icon jonschlinkert

Made tests work

Open Pimm opened this issue 7 years ago • 3 comments

For me (should 13.2.1), all tests always pass. Even when I trash the implementation.

It seems ….should.be.true returns a function. Calling that function makes the tests behave as expected for me.

Pimm avatar May 14 '18 12:05 Pimm

It seems ….should.be.true returns a function. Calling that function makes the tests behave as expected for me.

a previous version of should used that format.

jonschlinkert avatar Jun 05 '18 11:06 jonschlinkert

A previous version of should use the format without the call?

I npm installed, and received (and tested with) should version 13.2.1.

Pimm avatar Jun 05 '18 11:06 Pimm

Sorry I was just clarifying why the methods were written that way previously. Thank you for the PR, I’ll merge ASAP

jonschlinkert avatar Jun 05 '18 12:06 jonschlinkert