clone-deep icon indicating copy to clipboard operation
clone-deep copied to clipboard

Published 20 hours ago • verified publisher icon jonschlinkert

Handle circular references

Open emahuni opened this issue 3 years ago • 4 comments

This handles circular references cloning, still working on tests, but it works.

emahuni avatar Aug 02 '22 12:08 emahuni

This will help our team quite a bit. Thanks and can't wait until this is merged

aaronlippold avatar Aug 23 '22 20:08 aaronlippold

Hi,

This PR add dependencies to lodash.

I don't think it's required. Also, I chose this library to avoid this kind of dependencies.

cloneArrayDeep is merged into cloneObjectDeep, benchmark might be required before merge.

Regards,

Dallas62 avatar Aug 25 '22 06:08 Dallas62

Hi,

This PR add dependencies to lodash.

I don't think it's required. Also, I chose this library to avoid this kind of dependencies.

cloneArrayDeep is merged into cloneObjectDeep, benchmark might be required before merge.

Regards,

You are correct about dependencies, I also worry about that, but it's not the entire lodash lib. I didn't add the whole lib, just what was needed. For this reason there is then a room for improvement, but that's the concept overall.

emahuni avatar Aug 26 '22 15:08 emahuni

If someone is interested in updating this PR without lodash, I'd be happy to merge it in.

jonschlinkert avatar Jul 12 '23 23:07 jonschlinkert