ud-annotatrix icon indicating copy to clipboard operation
ud-annotatrix copied to clipboard

Fixed wide window

Open gstark0 opened this issue 7 years ago • 9 comments

@jonorthwash Could you confirm that this solves the issue? Because it does not happen to me :(

gstark0 avatar Jan 15 '18 06:01 gstark0

@gstark0 @jonorthwash Doesn't happen to me either.

On a side note, correct me if I am wrong, but is this not a fully annotated tree, i.e. didn't add anything under 'beach'? screen shot 2018-01-14 at 10 55 21 pm But the progress seems to be at 100%.

JPJPJPOPOP avatar Jan 15 '18 06:01 JPJPJPOPOP

No, beach is empty, shouldnt be Like that.

gstark0 avatar Jan 15 '18 07:01 gstark0

@gstark0 Yeah, that was what I was talking about.

JPJPJPOPOP avatar Jan 15 '18 07:01 JPJPJPOPOP

I know why, it’s becuase you have cycle, and the progress bar detects additional arc as the remaining element. So, it works as intended.

gstark0 avatar Jan 15 '18 07:01 gstark0

Ahh, okay.

JPJPJPOPOP avatar Jan 15 '18 07:01 JPJPJPOPOP

@gstark0 the tree shouldn't be fully annotated if the root node isn't set. :)

ftyers avatar Jan 15 '18 08:01 ftyers

Where's there a cycle in what I posted?

What I suspect is that it has to do with my window width. I use narrower browser windows than the FHD full screen size that most people test with. Have you tested by making the browser window a bit smaller?

jonorthwash avatar Jan 15 '18 13:01 jonorthwash

the tree shouldn't be fully annotated if the root node isn't set. :)

Yeah, simply counting arcs isn't enough. You need to make sure that each node is a dependent of something, and that one of them is root. And perhaps it should interact with loop detection?

jonorthwash avatar Jan 15 '18 13:01 jonorthwash

@jonorthwash I meant cycle on jjjppp's picture. I made the window narrower on Chrome and Safari, looked like the issue doesn't exist there, but I suspect it's because of OS, as me and @JPJPJPOPOP are using MacOS, this may be why there's no issue here. I will fix that issue with counting.

gstark0 avatar Jan 15 '18 13:01 gstark0