asyncio-redis
asyncio-redis copied to clipboard
Python 2 Trollius support
I've modified asyncio-redis to run on Python 2 using Trollius. You can see my fork branch trollius_compat
I like this adaptor, and despite redoing/omitting sections (type checking), I believe it (as a separate package) may help others move to an AsyncIO/Trollius world.
I don't expect you to pull in my branch (suggest you don't). Let's use this issue as a discussion point to see whats next (it passes the examples).
Hi @benjolitz
Thank you! This is great. I won't merge this indeed, but this is very nice for the people using Trollius. I make a link to your fork in the README.
I propose renaming the port to something like 'trollius-redis' or 'asyncio-redis-python2' -- what do you think?
I really would like this port to be accessible from PyPI as I make use of it in our Python 2 infrastructure (your driver, ported to python 2, made code wonderfully simple). But I'd like to keep you involved, considering you wrote the thing -- I merely updated the yield froms to work in Py2 and did a minor decorator reimplementation of the type checker/function spawner.
Thanks. I like trollius-redis as a name.
Alright. It took a fuck ton of work to reimplement the type checker and pass all the tests.
I still need to correct the documentation and docstrings. I have no idea if sphinx even works.
https://github.com/benjolitz/trollius-redis
Cheers Ben
Yes, I can imagine that. I appreciate it!
Note that the link in the README is broken :)