Jonathan Hefner
Jonathan Hefner
Yes, with #44179, users could call `Rails.application.message_verifiers.rotate(...)` sometime before the `"active_storage.verifier"` initializer runs. Note that the `MessageVerifier` returned by `app.message_verifier("ActiveStorage")` [uses `Rails.application.key_generator` for its secret](https://github.com/rails/rails/blob/fd7c7733870b780dee5b66e5c0922dd9ad078556/railties/lib/rails/application.rb#L181). In other words, the old...
Related: #33347.
@skipkayhil Yes, there is still some follow-up work to be done (which I will get to soon), but I think this can be closed. Thank you, @grncdr! :pray:
After https://github.com/rails/rails/pull/39623#issuecomment-1251580872, I've given more thought to the API for rotating old `secret_key_base` values. I think a nice API might look something like: ```ruby Rails.application.message_verifiers.rotate(secret_key_base: old_secret_key_base) ``` The problem is...
@deivid-rodriguez My knowledge about Bundler's internals is limited, but that also seems like a reasonable approach. It would run once for each conflict (vs once for all conflicts in this...
> ...only wrapping the `runtime.setup` call, which only sets up the `$LOAD_PATH`, so I don't think it can raise `Gem::LoadError` except for this situation. ...I think we can scope this...
Unfortunately, #44666 does not actually fix the issue. If you change `Post.column_names` to `Post._default_attributes.keys` in the reproduction script, you will get the same error.
_YOU ARE HERE: :round_pushpin: Bikeshed_ Action Notifier has a bit of linguistic overlap with `ActiveSupport::Notifications`. If we are considering alternative names, what about Action Push?
Looking at [RDoc's `find_include_file`](https://github.com/ruby/rdoc/blob/4e14158255ad8de64041105470d88f66b6e22e98/lib/rdoc/markup/pre_process.rb#L288-L296), I believe it will resolve paths relative to the current file's directory. Therefore, we should be able to just write `:include: ../README.rdoc` in e.g. `activesupport/lib/active_support.rb`
> Is this something you are doing? No, I just wanted to make sure all the cases were covered. :smile: I wasn't sure how much aliased attributes were used at...