Feedback on the gitian tutorial

[justinmoon]

trafficstars

Super helpful.

Maybe in this section you could have people create another branch off of master? The previous section you make a branch and if you just copy the commands and push you'll end up with 2 commits on one PR. Seems like people usually do multiple PR -- one with "signed" stuff and another "unsigned". Edit: Made a PR for this.

And for some reason this command:

wget -O osslsigncode-2.0.tar.gz -P inputs https://github.com/mtrojnar/osslsigncode/archive/2.0.tar.gz

downloaded the file as gitian-builder/osslsigncode-2.0.tar.gz. The -P inputs didn't seem to have any effect (should download it as gitian-builder/inputs/osslsigncode-2.0.tar.gz). This caused an error during bin/gbuild -i --commit signature=v${VERSION} ../bitcoin/contrib/gitian-descriptors/gitian-win-signer.yml.

[justinmoon]

And maybe mention including a GPG pubkey in your first PR

[justinmoon]

Also, it seems like the bitcoin/contrib/gitian-build.py script can simplify some of this stuff. For instance, this one command will build and sign both the signed and unsigned executables.

./gitian-build.py  --build --sign $SIGNER $VERSION

[justinmoon]

gitian-build.py makes two nice little commits as well ... on master though ...

[jonatack]

Thanks for the PR @justinmoon. Happy to review and merge any other proposals you have.

[justinmoon]

The downside of gitian-build.py is that since it does everything, when if fails you need to start all over. So not sure if it actually helps.