webgrind icon indicating copy to clipboard operation
webgrind copied to clipboard

Convert config.php to config.ini

Open patcon opened this issue 12 years ago • 3 comments

myplanetdigital/chef-webgrind#4

Wondering whether it would be acceptable to use an ini file for config, as this works more cleanly with sysadmin's systems integration tools, which might want to drop in a config file and have things Just Work.

Also, it strikes me as a little odd to have functions at the bottom of the config file -- wouldn't we want to keep the config isolated, and hide that logic. Seems it would make upgrading webgrind more straightforward

http://php.net/manual/en/function.parse-ini-file.php

patcon avatar Dec 02 '12 21:12 patcon

:+1: this would be much cleaner than a php config that would break between releases

anusch-athari avatar Dec 02 '12 22:12 anusch-athari

Why would putting the config in a php file break any more than using an ini file? From the looks of it this project is designed for simplicity. Tossing in an ini file creates an additional layer of complexity and a new type of file format to deal with.

blobaugh avatar May 30 '14 06:05 blobaugh

There's a php builtin func: http://www.w3schools.com/php/func_filesystem_parse_ini_file.asp

I'd say it's a small ops code-smell to be writing config management assets to mess around with config in an executable file. I guess my thinking was that INI files were invented to avoid that :) I've written a lot of chef cookbooks, and webgrind was the first mature tool where i saw this

Anyhow, I'm not working with webgrind atm, so I suppose I'm indifferent

patcon avatar Jun 04 '14 06:06 patcon