docker-hugo icon indicating copy to clipboard operation
docker-hugo copied to clipboard

Dropped privs + HUGO_NEW

Open bitorius opened this issue 7 years ago • 3 comments

Hi! I posted on your GH issue - https://github.com/jojomi/docker-hugo/issues/20

I realize there are more changes than were necessary, but feel free to push back on anything you don't like. The temp file basically seeds the permissions so we can drop into the "hugo" user ASAP. I've added an "autodetect" of our external IP so we don't need to bind to 0.0.0.0. I shouldn't be developing on a DMZ tsk tsk..

anyway, let me know.

bitorius avatar Jan 04 '18 01:01 bitorius

To be honest, I'm not entirely sure what the entrypoint file does. Say, as compared to setting VOLUME in the Dockerfile, and using docker run.

hutson avatar Jan 14 '18 03:01 hutson

@avinashmx Thanks for rebasing on master again. Would merging this mean that users of this image had to change anything?

jojomi avatar Mar 08 '18 19:03 jojomi

No, it should just work. Backwards compatible. I merged the - with the exception of the HUGO_WATCH if statement which was fixed. See https://github.com/avinashmx/docker-hugo/commit/887d19938eee2c0a37796a81c33c1a9e4af7c5e6#diff-1b0c2b516b83393edb7200ad5ff12181

bitorius avatar Mar 08 '18 19:03 bitorius