johanrd comments

Repositories
Issues
Comments

Results 93 comments of


                                            johanrd

Convert `@sentry/ember` addon to V2 addon format

Side note: Having Sentry as a v2 addon will also for "free" remove the four separate build steps for: https://github.com/getsentry/sentry-javascript/blob/ea20d8db38f334f01e7c1581ddc0ded16c3bbb27/packages/ember/package.json#L37-L40 Since these are direct dependencies of a v1 addon, they...

[Bug] Transition to same route without parameters creates error `Uncaught TypeError: routeInfos[(routeInfoLength - 1)] is undefined` when a `queryParam` has default value `null`

For info, the stack trace leads to this method: https://github.com/emberjs/ember.js/blob/cca69654f5f23251919c454507465ec2792c642c/packages/%40ember/routing/router.ts#L1146-L1152

popovertarget on button type=button in form doesn't work

great, there is also a bug report for this being tracked here https://bugs.webkit.org/show_bug.cgi?id=261945