python-oauth2 icon indicating copy to clipboard operation
python-oauth2 copied to clipboard

Lowercase scheme and authority per specification.

Open joestump opened this issue 10 years ago • 8 comments
trafficstars

Closes #29. More robustly follows URL normalization per the specification now. See #133 for additional and related discussion.

joestump avatar Aug 02 '15 20:08 joestump

@jaitaiwan I'm not sure what's going on, but it appears PT3K support never passed tests? Or isn't merged into develop? Not really sure; everything says up to date with master/develope locally.

joestump avatar Aug 02 '15 21:08 joestump

We never ended up merging any py3k support into develop at all because mine was too incomplete. I don't know how it passed tests originally but it's not working now. I think the vote was on using tseaver's py3k branch and fixing the 2 tests that didn't pass.

jaitaiwan avatar Aug 02 '15 21:08 jaitaiwan

Somehow .travis.yml is running PT3K tests. No idea why because it's not in this branch?

joestump avatar Aug 02 '15 23:08 joestump

@jaitaiwan looks like you pushed PT3K builds to develop in c3d8b72e4a44d9285f4ea8cd81c8b9e20ef1783f. Can you back that out and move that over to the PT3K branch until it's merged in so we can merge this for 1.9RC1?

joestump avatar Aug 02 '15 23:08 joestump

Sure not a problem.

jaitaiwan avatar Aug 02 '15 23:08 jaitaiwan

@joestump change has been completed and RC1 has been tagged in a release/1.9 branch :)

jaitaiwan avatar Aug 02 '15 23:08 jaitaiwan

Tests are passing. This is ready for a final review. :+1:

joestump avatar Aug 02 '15 23:08 joestump

I pulled this PR into a new fork: https://github.com/TimSC/python-oauth10a

TimSC avatar Jan 13 '18 23:01 TimSC