python-oauth2 icon indicating copy to clipboard operation
python-oauth2 copied to clipboard

Published 20 hours ago • verified publisher icon joestump

Refactor Signer class

Open robkinyon opened this issue 12 years ago • 4 comments
trafficstars

This is to allow oauth2 to be usable in asynchronous frameworks such as Twisted or Tornado. Currently, the Signer class is commingled into the Client class, forcing all usage of signed requests to be over httplib2, thus synchronous. By breaking the act of signing out from the act of making the request, oauth2 becomes usable in asynchronous frameworks.

robkinyon avatar Jan 26 '13 00:01 robkinyon

@robkinyon Thanks a lot for this patch. I'd love to get it merged in, but @jaitaiwan and I have been merging in other PRs and it looks like this needs to be updated with master. It also needs test coverage before we can merge.

joestump avatar Jul 29 '15 03:07 joestump

Further to @joestump's comment it would be awesome if you could also squash your commits too before submitting the PR. Thanks!

jaitaiwan avatar Jul 29 '15 11:07 jaitaiwan

It's been a couple years (and a couple jobs) since I created this PR. I'm going to have to rebuild my fork and put my changeset on a proper branch before I can figure this out. Give me a few weeks.

robkinyon avatar Jul 29 '15 14:07 robkinyon

Thanks @robkinyon! Much appreciated. Will need to resubmit the PR against the develop branch so I'll leave this open as a reminder till we get the new PR

jaitaiwan avatar Jul 29 '15 23:07 jaitaiwan