vscode-remote-x11 icon indicating copy to clipboard operation
vscode-remote-x11 copied to clipboard

Published 20 hours ago • verified publisher icon joelspadin

Bastion

Open rcketscientist opened this issue 5 years ago • 5 comments
trafficstars

I want to change the lazy jumpHost to three values and just properly check them, but the basics should hold.

rcketscientist avatar Oct 23 '20 03:10 rcketscientist

This should be ready for review. Could likely use another cleanup pass, but the logic is stable in my limited use case at least.

rcketscientist avatar Oct 27 '20 00:10 rcketscientist

Thanks! Will take a look when I get some time.

joelspadin avatar Oct 27 '20 05:10 joelspadin

Other than dropping the try, I think that all makes sense. It may be some time before I can gather all those. Feel free to tweak as desired if you'd like to merge in the meantime

rcketscientist avatar Nov 02 '20 13:11 rcketscientist

Other than dropping the try, I think that all makes sense.

Did I leave in a comment about getting rid of the try? If so, ignore that. I had originally written something like that but then realized you were intentionally falling back to regular settings if parsing SSH config failed. I intended to replace that with my comment about splitting the parsing out so the try block is short and easy to follow.

joelspadin avatar Nov 03 '20 00:11 joelspadin

Ironically, we just switched to 2fa, rendering all this useless for us. I can't really justify finishing the PR now, sorry. I'll answer any questions you may have.

rcketscientist avatar Nov 05 '20 14:11 rcketscientist