EnhancedDiscord icon indicating copy to clipboard operation
EnhancedDiscord copied to clipboard

Double click edit opens edit prompt regardless of message author

Open Column01 opened this issue 5 years ago • 3 comments
trafficstars

The double click edit will allow you to "edit" messages that weren't posted by you. It will raise an error from discord in the developer console if you change the message contents and then click save.

I'm using the beta branch for ED which also has a different version of that plugin compared to the stable branch it appears.

Possible solution

  • Check if the message was authored by the client, and if it wasn't, don't open the prompt.

Edit prompt on non-authored message

img

Error in console (standard discord error)

img

Column01 avatar Apr 15 '20 18:04 Column01

Guess it's about time this became a documented issue. Anyway, the reason this still exists is because it was my intention to add a "copy mode" for other people's messages that wouldn't allow you to attempt to edit the message. So the fix for this bug includes a new feature.

Also, a related issue with this plugin is that it no longer allows you to edit messages in channels you no longer have permission to post in. Unless the API has been updated, you can still do this, even though the UI normally blocks you.

joe27g avatar Apr 15 '20 18:04 joe27g

I was looking to patch the plugin myself and provide a fix for the issue but couldn't find how to get the client's user ID (found the message author info in the message object and was just going to compare the IDs).

Column01 avatar Apr 15 '20 18:04 Column01

I suppose this also applies to the click delete too then. EDIT: Maybe not. Should just alert the user if they don't have permissions to delete messages.

Column01 avatar Apr 15 '20 18:04 Column01