Johannes Soltwedel

Results 125 comments of Johannes Soltwedel

Here are the release notes: https://github.com/marcomusy/vedo/discussions/971 Maybe we just have to rename the `mesh.points()` to `mesh.vertices` [here](https://github.com/haesleinhuepf/napari-process-points-and-surfaces/blob/4b61d896b8b9e03e9c512e5dbd9cf20f7043cd04/napari_process_points_and_surfaces/_vedo.py#L125) Edit: Woops, accidentally clicked on close.

Hi @haesleinhuepf , I think keeping the `connected_components` functional with the current vedo version could be a bit tricky. I see two options: - Restrict this PR to only updating...

> Yes, that sounds great! Does the code-snippet work already? Just pulled it out of my fingers, not really ^^" I think editing the list of which is being iterated...

@haesleinhuepf , I re-implemented the deprecated `compute_connectivity` function in vtk. Turned out that `vedo_mesh.connected_vertices(idx)` only returns the 1-hop neighbors of the queried vertex, which is horribly slow to do as...

@haesleinhuepf Thanks for the review, here goes. Sorry about the `__main__` thing, I really forget to remove it all the time 🙈

@haesleinhuepf > Give pytest -k my_specific_test_to_try a try ;-) I know, I do use it, but in case a test fails find it very helpful to step through the test...

@haesleinhuepf so....can this go in? 👼 Happy new year btw :) Edit: I think with this going through, tests for #83 should also pass.

Hi @haesleinhuepf , pinging you here again - do you mind if I merge this? The bug with the changed API in the `repr_html` is causing some errors in the...

@haesleinhuepf good idea, shouldn't be that hard - the function could look something like this: ```Python def toggle_wireframe(layer: "napari.layers.Surface", viewer: 'napari.Viewer') -> None: viewer.layers[layer.name].wireframe.visible = True return None ```

> I presume this would introduce new dependencies. But I have zero experience. At least for the stuff I use, it's entirely in vedo, or can be plain numpy. Plus,...