Jeremy Wright

Results 377 comments of Jeremy Wright

Thanks @lorenzncode I thought I had that fixed. I'll figure out what's going on.

Thanks. The colors are probably being shifted because I did not merge master into this branch yet to catch the recent color changes. The location will take some more digging....

@adam-urbanczyk Actually, if I just run the door assembly code from the docs and display it with `cadquery.vis.show`, some colors are shifted/wrong. The STEP import/export feature was NOT used for...

@adam-urbanczyk The gold color of the v-slot parts above is because there is no color defined for those components, and `cadquery.vis.show` is defaulting to a different color than CQ-editor and...

@adam-urbanczyk @lorenzncode The parent location was not being applied correctly when the original assembly.export method is used. I've fixed that now and pulled in the srgb changes from master, so...

@adam-urbanczyk Yes, I'll see what I can figure out.

@adam-urbanczyk The `Assembly.export` method is actually duplicating the names throughout the STEP file, so it does not look like it is a problem with this importer. I find 14 different...

How do we do that without breaking things like constraints that use part names? We would have to remove the `Assembly.add` restriction on duplicate names, correct?

It turns out that the `exportStepMeta()` method has the same issue of applying names to the wrong level. It tries to flatten the assembly by default, and the name of...

#1858 was created because there is an oversight within #1782 that causes `exportStepMeta` to act differently than the standard `Assembly.export` method. I'm trying to fix that, not adding functionality, other...