finamp icon indicating copy to clipboard operation
finamp copied to clipboard

Published 20 hours ago • verified publisher icon jmshrv

[Redesign] Use system title bar on wayland

Open Komodo5197 opened this issue 6 months ago • 4 comments

This makes Finamp use the system title bar when on wayland. It seems to work on KDE, someone should test what this looks like on GNOME because it sounds like they have some unusual behaviour related to window decorations on wayland.

Komodo5197 avatar Jun 01 '25 23:06 Komodo5197

I can also check on swaywm when I'm back home 👍

Maxr1998 avatar Jun 02 '25 11:06 Maxr1998

Is gnome the only other window manager for Linux?

There are quite a few window managers on Linux, probably more than I could count right now. However, since Gtk is closely connected to GNOME, it makes sense to use that header bar style on GNOME to fit in. However, this will only apply to X11, on Wayland we'll change from header always enabled to header always disabled with this PR, which should be fine.

Maxr1998 avatar Jun 06 '25 12:06 Maxr1998

Omg you absolute legend that was bothering me so much haha <3 works on Hyprland :)) finally no title bar anymore

flloschy avatar Jun 06 '25 13:06 flloschy

I've seen comments that suggest GNOME specifically does not support server-side window decorations under wayland, while most other window managers do. So that's the one I'm most concerned about. I'm hoping GTK just handles everything for us, but I'm not 100% sure why flutter was using the defaults it was.

Komodo5197 avatar Jun 06 '25 18:06 Komodo5197

Alright, I guess it's best to let more users test this, thanks for the PR!

Chaphasilor avatar Jun 08 '25 12:06 Chaphasilor