vscode-nuget-package-manager icon indicating copy to clipboard operation
vscode-nuget-package-manager copied to clipboard

Published 20 hours ago • verified publisher icon jmrog

Enhancement: Dont remove comments in csproj

Open CarlosAzocar opened this issue 8 years ago • 3 comments

Dont delete comments in csproj after installing package

CarlosAzocar avatar Mar 13 '17 14:03 CarlosAzocar

Thanks. This is another good suggestion. The current behavior is a result of the fact that, for whatever reason, the XML parser that this extension uses, 'xml2js', strips out comment nodes. There is an open PR on xml2js from 2012 that addresses this, but it looks like there hasn't been any progress made since then. Unfortunately, this means that the solution here is probably going to involve swapping out dependencies, and possibly writing some parsing of our own using sax.js.

jmrog avatar Mar 13 '17 14:03 jmrog

In the meantime, I'll add the fact that comments get stripped to the "Known Issues" for this extension.

jmrog avatar Mar 13 '17 14:03 jmrog

Marking as "help wanted" since I've had very little time to dedicate to this lately, and don't expect that to change too soon.

jmrog avatar May 20 '17 01:05 jmrog